Skip to content

Spotless Gradle Plugin fails Gradle 8.1 with configuration cache enabled #1644

Closed
Closed
Spotless Gradle Plugin fails Gradle 8.1 with configuration cache enabled#1644
Labels
bug

Description

@BraisGabin
BraisGabin
opened on Mar 29, 2023

Spotless Gradle Plugin 6.17.0 (it also happens with 6.11.0) makes the configuration cache fail on Gradle 8.1-rc-1. This happens just to have the plugin applied. No need to execute any spotless' task.

On macOS I get 4 errors:

> Starting an external process 'bash --login -c which git' during configuration time is unsupported.
> Starting an external process 'xcode-select -p' during configuration time is unsupported.
> Starting an external process '/usr/bin/git --version' during configuration time is unsupported.
> Starting an external process '/usr/bin/git config --system --show-origin --list -z' during configuration time is unsupported.

On Linux I get 2 errors:

> Starting an external process '/usr/bin/git --version' during configuration time is unsupported.
> Starting an external process '/usr/bin/git config --system --show-origin --list -z' during configuration time is unsupported.

The message error also points to this documentation: https://docs.gradle.org/8.1-rc-1/userguide/configuration_cache.html#config_cache:requirements:external_processes

Here you have the 4 stack traces of those errors (from macOS):

org.gradle.api.InvalidUserCodeException: Starting an external process '/usr/bin/git --version' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1534)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

org.gradle.api.InvalidUserCodeException: Starting an external process '/usr/bin/git config --system --show-origin --list -z' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1573)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

org.gradle.api.InvalidUserCodeException: Starting an external process 'bash --login -c which git' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS_POSIX.discoverGitExe(FS_POSIX.java:150)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1526)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

org.gradle.api.InvalidUserCodeException: Starting an external process 'xcode-select -p' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS_POSIX.discoverGitExe(FS_POSIX.java:169)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1526)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

I could create a reproducer if needed.

Activity

  1. illarionov
    added a commit that references this issue on Apr 2, 2023

    Workaround diffplug/spotless#1644

    44710bb

  2. nedtwigg commented on Apr 3, 2023

    @nedtwigg
    nedtwigg
    on Apr 3, 2023
    Member

    Thanks for the error report! This is probably going to hit us in a few places

    This change in 8.1 seems likely to wreak havoc in the plugin ecosystem, maybe some mitigations will become available...

  3. nedtwigg
    added
    bug
    on Apr 3, 2023
  4. liblit
    added this to Use Gradle configuration cacheon Apr 20, 2023
  5. github-project-automation
    moved this to Todo in Use Gradle configuration cacheon Apr 20, 2023

  6. BraisGabin commented on Apr 24, 2023

    @BraisGabin
    BraisGabin
    on Apr 24, 2023
    Author

    There is a workaround for this issue:

    spotless {
    // https://github.com/diffplug/spotless/issues/1644
    lineEndings = LineEnding.PLATFORM_NATIVE // or any other except GIT_ATTRIBUTES
}
  7. marcphilipp
    added a commit that references this issue on Apr 28, 2023

    Work around diffplug/spotless#1644

    1f8f24d
  8. geiralund
    added a commit that references this issue on May 3, 2023

    Oppdatere spotless plugin. Setter lineEndings eksplisitt ref diffplug…

    a249288
  9. torresmi
    added a commit that references this issue on Jun 10, 2023

    Downgrade Gradle for Spotless bug

    1331dd8
  10. chrisbanes
    added 7 commits that reference this issue on Jul 20, 2023

    Workaround Spotless config cache

    a9b230a

    Workaround Spotless config cache

    8e2c337

    Workaround Spotless config cache

    12eafc6

    Workaround Spotless config cache

    9dd8ddc

    Workaround Spotless config cache

    e69b777

    Workaround Spotless config cache

    62e1811

    Workaround Spotless config cache

    4be1080
  11. nedtwigg
    closed this as completedin b99ec3don Aug 7, 2023
  12. github-project-automation
    moved this from Todo to Done in Use Gradle configuration cacheon Aug 7, 2023
  13. geiralund
    added 3 commits that reference this issue on Aug 17, 2023

    Workaround for <diffplug/spotless#1644>

    be12a5e

    Workaround for <diffplug/spotless#1644>

    510a097

    Workaround for diffplug/spotless#1644

    592df7e

  14. nedtwigg commented on Sep 1, 2023

    @nedtwigg
    nedtwigg
    on Sep 1, 2023
    Member

    Released in plugin-gradle 6.21.0

  15. geiralund
    added a commit that references this issue on Sep 12, 2023

    // Workaround for <diffplug/spotless#1644>

    4c124df
  16. blacelle
    added a commit that references this issue on Feb 15, 2024

    Fix Config Cache External Process Issue (diffplug#1777 fixes diffplug…

    b99ec3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions