ktlint_standard_enum-entry-name-case = disabled does not work on .editorconfig

The .editorconfig file

[*.{kt,kts}]
indent_style = space
indent_size = 4
ktlint_standard_no-wildcard-imports = disabled # works
ktlint_standard_filename = disabled # works
ktlint_standard_enum-entry-name-case = disabled # doesnt work

The error:

Error on line: 209, column: 4
rule: standard:enum-entry-name-case
Enum entry name should be uppercase underscore-separated names like "ENUM_ENTRY" or upper camel-case like "EnumEntry"

The gradle.kts

plugins {
        id("com.diffplug.spotless") version "6.20.0"
    }
...
spotless {
    kotlin {
        ktlint("0.50.0").setEditorConfigPath("$projectDir/../.editorconfig")
    }
}

Is this something you can help me figure out? I'm using the latest spotless gradle plugin, but I think this is related to ktlint. Let me know if I have to take this to the ktlint devs instead.

It works, see Goooler/AndroidOAuth2WebView#36.

I guess the issue is what you are using "$projectDir/../.editorconfig" to override file path.

The file path needs to be overridden because the project is a submodule of a bigger project.
The plugin fails if it can't find the file in the config path:

Could not determine the dependencies of task ':spotlessApply'.
> Could not create task ':spotlessKotlinApply'.
   > Could not create task ':spotlessKotlin'.
      > File signature can only be created for existing regular files, given: .../looker-sdk-codegen/.blablah

Plus, the other settings I have in the .editorconfig file seem to work fine.

You can use "$projectDir.parent/.editorconfig" here.

I'm getting odd behavior, and I'm not sure what happened but none of the settings work now.

I tried the path that you provided and tried the old one. There's no errors about the file not being found, but it does not seem to matter and it fails the validation.

What worked though was copying the .editconfig to the project directory and removing the setEditorConfigPath.
But I can't do that, not without telling the project maintainers that I now have to have two distinct .editorconfig files and that editor config path setting should work, right?

Overriing .editorconfig works, I just tried with a simular case in Goooler/AndroidOAuth2WebView#36, I guess you are still setting a wrong path.

Shouldn't the plugin fail if the file isn't found?

@nedtwigg

Shouldn't the plugin fail if the file isn't found?

I believe this is reasonable.

@nedtwigg WDYT?

If I change the file name or path I get an error.
The current behaviour ignores the file content if it's not in the root directory.

I fixed this by deleting the .gradle and build directories. Not sure why I had to do this, but spotlessApply is working fine after that.

Check if EditorConfig file exist for Ktlint (#1788 fixes #1785)

Navigation Menu

Repository navigation

ktlint_standard_enum-entry-name-case = disabled does not work on .editorconfig #1785

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

ktlint_standard_enum-entry-name-case = disabled does not work on .editorconfig #1785

Description

Activity

Goooler commented on Aug 23, 2023

daniel-lopes-optimizely commented on Aug 23, 2023

Goooler commented on Aug 23, 2023

daniel-lopes-optimizely commented on Aug 23, 2023

Goooler commented on Aug 23, 2023

daniel-lopes-optimizely commented on Aug 23, 2023

Goooler commented on Aug 23, 2023

daniel-lopes-optimizely commented on Aug 23, 2023

daniel-lopes-optimizely commented on Aug 23, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions