Repository navigation
Unreasonably large configuration performance overhead #348
Description
Activity
I think that line is using this static import:
Which then calls this:
not this:
because target is an
Object[], but I might be making a mistake. So I think it's only iterating over (N filecollections), not (file collection of size N).Sorry, I had linked the wrong line. Here is the real culprit:
Aha! Thanks very much for the bug find 👍
- added a commit that references this issue
on Feb 9, 2019 Published in 3.18.0
This line iterates the whole file collection, no matter if the task will execute or not. This is a large performance overhead, paid on every build invocation, no matter if spotless will be used or not. It should instead only check wether the collection itself is null.
spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/FormatExtension.java
Line 135 in b38ee5a