Repository navigation
Convert project_name to lowercase - #568
Merged
Merged
Conversation
Signed-off-by: Gabor Nagy <[email protected]>
|
Uppercase letters should actually be supported, this is a bug in docker 1.3 API , see #541 |
Author
|
@dnephin Thank you for your answer! How about the dot and the dash characters? Should I modify this pull request to allow them (and restore the uppercase support)? |
|
This lowercase fix would be beneficial to my organization adopting fig. Are there any plans to ship a release with it? |
|
LGTM |
aanand
added a commit
that referenced
this pull request
Jan 12, 2015
Convert project_name to lowercase
|
Woot!
|
This was referenced Feb 24, 2015
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Convert project_name to lowercase Signed-off-by: Yuval Kohavi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ fig up Creating FIGtest_test_1... Building test... Invalid repository name (FIGtest_test), only [a-z0-9-_.] are allowed $ cat fig.yml test: build: test/ $ cat test/Dockerfile FROM scratch $ basename $(pwd) FIG-testIMHO
.and-could be allowed in the anormalize_namemethod too. What is your opinion?