Skip to content

Fixes #602 Allowing help $cmd with no figfile - #606

Merged
aanand merged 1 commit into
docker:masterfrom
kojiromike:602-no-help-without-figfile
Nov 3, 2014
Merged

aanand merged 1 commit into
docker:masterfrom
kojiromike:602-no-help-without-figfile

Conversation

@kojiromike

Copy link
Copy Markdown

Signed-off-by: Michael A. Smith [email protected]

Comment thread tests/integration/cli_test.py Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this line, setUp() should reset it for every test

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this line, the test crashes during teardown. But that's definitely not obvious, so I'll put a comment in the code.

Signed-off-by: Michael A. Smith <[email protected]>
@bfirsh

bfirsh commented Nov 3, 2014

Copy link
Copy Markdown

LGTM

aanand added a commit that referenced this pull request Nov 3, 2014
Fixes #602 Allowing `help $cmd` with no figfile
@aanand
aanand merged commit 604b370 into docker:master Nov 3, 2014
@kojiromike
kojiromike deleted the 602-no-help-without-figfile branch November 3, 2014 14:24
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
…file

Fixes docker#602 Allowing `help $cmd` with no figfile
Signed-off-by: Yuval Kohavi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants