Repository navigation
add home link to logo - #201
Closed
Amitrochates wants to merge 2 commits into
Closed
Amitrochates wants to merge 2 commits into
Amitrochates wants to merge 2 commits into
Conversation
Philipinho
reviewed
Aug 26, 2024
| Docmost | ||
| </Text> | ||
| <Link | ||
| to="/home"> |
Member
There was a problem hiding this comment.
The Text component is polymorphic (See https://mantine.dev/core/text/#polymorphic-component).
To maintain existing styling, it should be:
<Text
size="lg"
fw={600}
style={{ cursor: "pointer", userSelect: "none" }}
component={Link}
to="/home"
>
Docmost
</Text>
vvzvlad
pushed a commit
to vvzvlad/gitmost
that referenced
this pull request
Jun 26, 2026
…rmanent (docmost#201) "Temporary notes" with a death timer: created via a dedicated hourglass button in the space-tree header, a note auto-moves to Trash after a configurable X hours (default 24) unless explicitly made permanent ("structure or die"). Reuses existing mechanisms, mirroring is_template and the trash-cleanup job: - New nullable column pages.temporary_expires_at (NULL = permanent; non-NULL = frozen deadline) + partial index for the sweep; workspace column temporary_note_hours (default via DEFAULT_TEMPORARY_NOTE_HOURS = 24). - create-page DTO `temporary` flag; the deadline is frozen at creation so later setting changes never reschedule existing notes. - POST /pages/toggle-temporary (mirror of toggle-template): arm/clear the timer, CASL-guarded via validateCanEdit, cross-workspace NotFound defense-in-depth. - TemporaryNoteCleanupService: hourly @interval sweep that soft-deletes expired notes through the exact PageRepo.removePage path (recursive over children, emits PAGE_SOFT_DELETED), attributed to the creator; idempotent via deletedAt IS NULL filters. - restorePage clears temporary_expires_at so a restored note can't be re-trashed. - Workspace setting temporary_note_hours (audit-tracked) + a hours editor in workspace General settings. - Client: second create button, orange tree icon, tree + page-header menu toggle ("Make temporary"/"Make permanent"), an open-note banner with a rescue action, and en/ru i18n. Tests (unit): toggle-temporary controller (toggle/explicit/permission/cross-ws + DTO validation), cleanup-job sweep (selection filters, per-note removePage, error isolation), and a migration up/down sanity. Server tsc, client tsc -b, and the page+workspace jest suites are green. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vvzvlad
pushed a commit
to vvzvlad/gitmost
that referenced
this pull request
Jun 26, 2026
Must-fix: - CHANGELOG: add [Unreleased]/Added entry for temporary notes (docmost#201). - temporary-note-cleanup: re-check temporary_expires_at at deletion time so a concurrent "Make permanent" (sets it NULL) between the batch SELECT and the per-row removePage wins the race and the note is not trashed. Add unit tests for the make-permanent and already-trashed race windows. Non-blocking review items: - temporary-note-cleanup: cap the sweep batch (LIMIT 500) so a large backlog is not loaded into memory; remainder drains on the next hourly run. - client: extract duplicated post-toggle cache sync into syncTemporaryExpiresInCache() shared by the header menu and the banner. - Remove the tautological migration spec that mocked the whole Kysely builder. - Tests: cover create() frozen temporaryExpiresAt (workspace override + NULL default fallback + non-temporary skips lookup) and restorePage disarming the timer (temporaryExpiresAt: null). Deferred (forward-looking, non-blocking): extract PageService.computeTemporaryExpiresAt() to dedupe the deadline formula and drop the @InjectKysely from PageTemplateController; replace migration unit test with a real Postgres up/down integration test. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vvzvlad
pushed a commit
to vvzvlad/gitmost
that referenced
this pull request
Jun 26, 2026
…ocmost#201) develop merged 20260626T130000-share-aliases; rename this PR's migration to 20260626T140000 so the two no longer share a timestamp prefix. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vvzvlad
pushed a commit
to vvzvlad/gitmost
that referenced
this pull request
Jun 26, 2026
…hours unless made permanent (docmost#201)' (docmost#215) from feat/201-temporary-notes into develop Reviewed-on: https://gitea.vvzvlad.xyz/vvzvlad/gitmost/pulls/215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves issue #151 by
adding a link to homepage on clicking the docmost logo.