Repository navigation
feat: lightbox media display - #2420
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a lightbox-based media viewer to the page editor so users can open images/videos in an overlay and navigate/download/fullscreen them, addressing issue-tracker #7.
Changes:
- Introduces a new
LightboxViewcomponent backed byyet-another-react-lightboxto render page media in an overlay. - Adds “Open image” / “Open video” actions to the image/video bubble menus and wires state via a new Jotai
lightboxRequestAtom. - Updates client dependencies/lockfile and adds new i18n keys (en-US).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds yet-another-react-lightbox and updates lock metadata (now includes new deprecation notices). |
| apps/client/package.json | Adds yet-another-react-lightbox dependency. |
| apps/client/src/features/editor/page-editor.tsx | Wires LightboxView into the editor and connects it to lightboxRequestAtom. |
| apps/client/src/features/editor/components/video/video-menu.tsx | Adds “Open video” action to trigger lightbox. |
| apps/client/src/features/editor/components/image/image-menu.tsx | Adds “Open image” action to trigger lightbox. |
| apps/client/src/features/editor/components/common/lightbox-view.tsx | New lightbox overlay component that collects page media and configures plugins (download/fullscreen/video/zoom/captions). |
| apps/client/src/features/editor/atoms/editor-atoms.ts | Adds LightboxRequest type and lightboxRequestAtom. |
| apps/client/public/locales/en-US/translation.json | Adds new i18n strings for the lightbox actions and fallback label. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+189
to
190
| const [lightboxRequest, setLightboxRequest] = useAtom(lightboxRequestAtom); | ||
| const [isLocalSynced, setIsLocalSynced] = useState(false); |
Comment on lines
+98
to
+101
| const slides = useMemo( | ||
| () => getPageMedia(editor), | ||
| [editor, open, i18nInstance.language] | ||
| ); |
Comment on lines
+297
to
+299
| "Media": "Media", | ||
| "Open image": "Open image", | ||
| "Open video": "Open video", |
Comment on lines
+4994
to
+4997
| '@xmldom/[email protected]': | ||
| resolution: {integrity: sha512-KRYzxepc14G/CEpEGc3Yn+JKaAeT63smlDr+vjB8jRfgTBBI9wRj/nkQEO+ucV8p8I9bfKLWp37uHgFrbntPvw==} | ||
| engines: {node: '>=10.0.0'} | ||
| deprecated: this version has critical issues, please update to the latest version |
Comment on lines
6323
to
6327
| [email protected]: | ||
| resolution: {integrity: sha512-ocgh41VhRlf9+fVpe7QKzwLj9c92fDiqOj8Y3Sd4/ZmVA4Btx4PlUYPq4pp9JDyupkf1upbEXecxL2mwNV7jPQ==} | ||
| engines: {node: ^18.18.0 || ^20.9.0 || >=21.1.0} | ||
| deprecated: This version is no longer supported. Please see https://eslint.org/version-support for other options. | ||
| hasBin: true |
- support readonly mode - use softer backdrop - other enhancments
qwq0318
pushed a commit
to IM-PING-CLUB/docmost
that referenced
this pull request
Sep 22, 2026
Brings in image preview lightbox (PR docmost#2420, v0.96.0) and page tree reordering fix (6205bbe). OEM customizations preserved across 5 conflict files (username login, OEM_HIDE_* flags, branding). Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/docmost/issue-tracker/issues/7
lightbox.1.mov
lightbox.2.mov