Repository navigation
Add API description - #503
Closed
nuclearpolygon wants to merge 4 commits into
Closed
nuclearpolygon wants to merge 4 commits into
nuclearpolygon wants to merge 4 commits into
Conversation
|
|
Author
|
Hi there! Sorry for not being around for a while. Maybe lets resolve the conflict and merge? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
It would be really helpful to merge this. I was under impression that Docmost doesn't have APIs exposed, and was going to see other products, but luckily I checked Issues and PRs first |
Member
|
Thanks for sharing your work. |
vvzvlad
pushed a commit
to vvzvlad/gitmost
that referenced
this pull request
Jul 12, 2026
…anon Issue docmost#503 reported a hardBreak sent via updatePageJson being «silently cut» — no error, no line break — forcing the agent to split lines into separate paragraphs. A faithful repro shows the bug does NOT reproduce against develop: hardBreak is fully representable in the markdown canon in BOTH directions and survives the real Yjs write path. - pm -> md: the serializer (now in @docmost/prosemirror-markdown after the docmost#293 STEP 5 consolidation) emits the CommonMark hard break ` \n`, not a bare `\n`. - md -> pm: marked tokenizes ` \n` to `<br>`, which generateJSON parses back to a hardBreak node in ONE paragraph (not split, not dropped). - updatePageJson (PM JSON -> applyDocToFragment = PMNode.fromJSON + updateYFragment, the real collab-session write encoder -> read back) keeps text + hardBreak + text in one paragraph. The issue's diagnosis points at packages/mcp/.../markdown-converter.ts as the serializer, but that file is a 15-line re-export shim since docmost#293 STEP 5 — the diagnosis predates the converter consolidation that already closed both sides. P1 (semantic round-trip) + P2 (byte-fixpoint) hold, and the node already has broad property/corpus/golden coverage in the package. No converter change is warranted (switching the break form to `\`+newline would churn the whole docmost#351 byte-fixpoint corpus against the established ` \n` repo convention for zero functional gain). This adds one integration guard at the MCP canon seam covering all three seams of the reported updatePageJson path. Mutation-verified: neutering the serializer arm or the importer `<br>` handling reddens seams 1-2; neutering the real applyDocToFragment write path reddens seam 3. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vvzvlad
pushed a commit
to vvzvlad/gitmost
that referenced
this pull request
Jul 12, 2026
…ocmost#293) — регресс-гард, закрытие docmost#503' (docmost#544) from fix/503-hardbreak-canon into develop Reviewed-on: https://gitea.vvzvlad.xyz/vvzvlad/gitmost/pulls/544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a postman collection describing most of API endpoints and parameters. It is not perfect but it's a good starting point. I intend to improve the docs on it when I have some spare time.
Summary by CodeRabbit