Skip to content

Add health check and development script - #52

Closed
will2hew wants to merge 2 commits into
docmost:mainfrom
will2hew:will/health
Closed

will2hew wants to merge 2 commits into
docmost:mainfrom
will2hew:will/health

Conversation

@will2hew

@will2hew will2hew commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

Adds a simple health check endpoint that verifies the connection to the database.

This also contains a development server script I personally find helpful, but am happy to remove if you'd prefer.

Closes #49

@CLAassistant

CLAassistant commented Jul 4, 2024 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread apps/server/src/integrations/health/health.controller.ts
Comment thread package.json
@will2hew

will2hew commented Jul 5, 2024

Copy link
Copy Markdown
Contributor Author

@Philipinho I have added the requested redis check and logging.

I would note, that currently the entire application crashes when Postgres and/or Redis connections are lost, so this health check does perform its job - we should probably make the app fail in a more graceful way. I think that should be a follow up to this however.

Comment thread apps/server/src/integrations/health/health.controller.ts
@Philipinho

Philipinho commented Jul 5, 2024 •

Copy link
Copy Markdown
Member

that currently the entire application crashes when Postgres and/or Redis connections are lost

It only crashes when the database connection fails during startup after 10 retries. Once the app is running, lost db connections do not crash it. Edit: I discovered the bug that led to it crashing the server after startup. Fixed now.

A lost Redis connection will not crash it, both during startup and while running. Redis retries indefinitely.

@Philipinho Philipinho mentioned this pull request Jul 5, 2024
@Philipinho

Copy link
Copy Markdown
Member

I could not add my commits here. I created a new branch #64.
I will merge the new branch after you review it (If you've got time).
Thank you for your contribution.

@Philipinho Philipinho closed this Jul 5, 2024
Vito0912 added a commit to fuscodev/docmost that referenced this pull request Jul 5, 2025
vvzvlad pushed a commit to vvzvlad/gitmost that referenced this pull request Jun 20, 2026
…t#56

Keep the backlog focused on deferred TESTS; the related non-test gaps
(model-allow-list, restriction-cache invalidation, server embed-recursion
guard, collectPageEmbeds cycle guard, jest DI/lib0-ESM debt) are now
tracked as issues docmost#52-docmost#56 and only linked from the backlog.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
vvzvlad pushed a commit to vvzvlad/gitmost that referenced this pull request Jun 20, 2026
vvzvlad pushed a commit to vvzvlad/gitmost that referenced this pull request Jun 21, 2026
chatModel was a free string accepted with empty/garbage values, failing only at
runtime as a provider 503; tighten it (trim + non-empty + max 200). Driver was
already @isin(AI_DRIVERS). Collapse the client driver list to one AI_DRIVER_VALUES
source and add a contract test that reads the server AI_DRIVERS and fails on
client/server drift.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
PMQ9 referenced this pull request in cccvu/docmost Sep 2, 2026
test(client): #46 regression + complete passwordless migration (#52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Health endpoint

3 participants