Skip to content

feat: add HOST env option to listen on a different interface - #522

Closed
utf-4096 wants to merge 1 commit into
docmost:mainfrom
utf-4096:custom-listen-address-via-env
Closed

utf-4096 wants to merge 1 commit into
docmost:mainfrom
utf-4096:custom-listen-address-via-env

Conversation

@utf-4096

Copy link
Copy Markdown

This PR adds the HOST env variable to let users choose which interface the webapp should listen on.

I think it would be preferable for :: which listens on IPv4 & IPv6 to be the default in the future as that's what most servers do, and IPv6 adoption is increasing. For now though, this change allows users to enable support manually while keeping existing configs intact.

@CLAassistant

CLAassistant commented Nov 29, 2024 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@utf-4096 utf-4096 closed this by deleting the head repository Apr 23, 2025
vvzvlad pushed a commit to vvzvlad/gitmost that referenced this pull request Jul 12, 2026
…ss-package drift guard

Reviewer follow-up on the docmost#522 internal-link import fix. The fix itself is
confirmed correct; these three changes harden its load-bearing subset invariant
and fix a stale doc.

Finding 1 (drift guard): the in-package test only compared isInternalPagePath
against a HAND-COPIED server regex, so a later narrowing of the real server
INTERNAL_LINK_REGEX would leave the test green while the client silently became
WIDER than the server. Add apps/server/.../export/internal-link-parity.spec.ts:
the top layer already depends on @docmost/prosemirror-markdown and exports
isInternalPagePath, so this spec imports the LIVE server INTERNAL_LINK_REGEX AND
the LIVE isInternalPagePath and asserts subset over an accept-corpus — a server
narrowing now reddens CI. The in-package manual copy is demoted from its
"drift guard" role (comment updated to say so; it stays as local documentation).

Finding 2 (charset non-vacuity): the REJECT list was purely structural, so the
mutation widening the slug charset [a-zA-Z0-9-] -> [a-zA-Z0-9-.] survived the
whole suite. Add REJECT cases whose ONLY defect is a forbidden slug character
(abc.def / abc_def / abc%20 / abc~x); assert both isInternalPagePath and the
server regex reject them. The mutation now reddens the new reject test.

Finding 3 (stale JSDoc): canonicalize.ts KNOWN_DEFAULTS module blurb claimed
every entry was read from docmost-schema and import-materialized. The new
link.internal default breaks both claims (source is editor-ext/src/lib/link.ts;
external links leave internal absent/null, never false). Add a bullet documenting
the one editor-sourced, non-materialized default (false ≡ absent/null).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vvzvlad pushed a commit to vvzvlad/gitmost that referenced this pull request Jul 12, 2026
…ет внутренние ссылки на страницы как internal (docmost#522)' (docmost#524) from fix/522-internal-links into develop

Reviewed-on: https://gitea.vvzvlad.xyz/vvzvlad/gitmost/pulls/524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants