Repository navigation
[TrimmableTypeMap] Update TrimmableTypeMapBuildTests to expect a full successful build #11020
Description
Activity
I checked this against current
origin/main.This is mostly done now:
ThrowOnBuildFailure = falseis gone from the two original tests.Build_WithTrimmableTypeMap_Succeedsnow expectsbuilder.Build (proj)to succeed.Build_WithTrimmableTypeMap_IncrementalBuildexpects both builds to succeed.- The incremental test still asserts
_GenerateJavaStubsis skipped on the second build.
What is still missing from this issue's exact checklist:
- The original build tests only assert that the
typemapintermediate directory exists. - They do not explicitly assert that
_Microsoft.Android.TypeMaps.dlland_Mono.Android.TypeMap.dllwere generated. - They do not explicitly assert that JCW
.javafiles were generated under the typemap output directory.
There is related coverage elsewhere:
GenerateTrimmableTypeMapTestschecks those DLL names at task level, andBuild_WithExportAndExportField_GeneratesJcwAndTypeMapchecks JCW output plus a user*.TypeMap.dll. But since this issue specifically asks to update the existingTrimmableTypeMapBuildTestsbuild tests, I think we should keep it open until those direct assertions are added toBuild_WithTrimmableTypeMap_Succeedsand likely reused by the incremental test after the first build.- added a commit that references this issue
on May 26, 2026 - locked and limited conversation to collaborators
on Jun 26, 2026
Parent issue: #11017
File:
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/TrimmableTypeMapBuildTests.csBoth existing tests currently use
ThrowOnBuildFailure = falsewith a comment that the build fails downstream because manifest generation was not yet implemented. Now that the trimmable path is complete (manifest, JCW generation, etc.), these tests should be updated to:ThrowOnBuildFailure = false— expect a full successful build_Microsoft.Android.TypeMaps.dlland_Mono.Android.TypeMap.dll.javafiles were generated in the typemap output directoryBuild_WithTrimmableTypeMap_IncrementalBuild) should already correctly assert that_GenerateJavaStubsis skipped on the second build — just remove the failure tolerance