Skip to content

[illink] Try to not preserve __TypeRegistrations classes #5515

Description

@radekdoulik

These should hopefully be not needed anymore as the new typemap should be sufficient.

Activity

  1. self-assigned this
    on Jan 18, 2021
  2. added this to the One .NET milestone on Jan 18, 2021
  3. radekdoulik commented on Jan 18, 2021

    @radekdoulik
    MemberAuthor

    @grendello does typemap handle all the managed to java type lookups? I wonder whether we can remove this part of code as well https://github.com/xamarin/xamarin-android/blob/7db5be8a56779fbcf0dc7f683d2831910b420d31/src/Mono.Android/Java.Interop/TypeManager.cs#L222-L237 Plus all the code related to package registration.

  4. grendello commented on Jan 18, 2021

    @grendello
    Contributor

    @radekdoulik Typemap handles all the types handed to it by the type scanner (from Java.Interop) and what it cannot find is handled in the managed code in a fallback path. It feels like removing the type registrations should work?

  5. radekdoulik commented on Feb 26, 2021

    @radekdoulik
    MemberAuthor

    Done.

    #5516
    #5629

  6. ghost locked as resolved and limited conversation to collaborators on Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions