Repository navigation
[linker] Do not preserve __TypeRegistrations - #5516
Merged
radekdoulik merged 3 commits intoFeb 3, 2021
Merged
Conversation
radekdoulik
marked this pull request as ready for review
January 28, 2021 14:28
radekdoulik
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
January 28, 2021 14:28
grendello
approved these changes
Jan 28, 2021
jonathanpeppers
approved these changes
Jan 28, 2021
| new RemoveSecurity (), | ||
| new MarkJavaObjects (), | ||
| new PreserveJavaExceptions (), | ||
| new PreserveJavaTypeRegistrations (), |
Member
There was a problem hiding this comment.
We could remove this in current Xamarin.Android, too? Nice.
dellis1972
approved these changes
Jan 29, 2021
radekdoulik
force-pushed
the
pr-remove-type-registrations
branch
from
February 3, 2021 11:09
002670d to
82beb33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #5515
The
__TypeRegistrationclasses should not be needed anymore asthe new typemap has all the information.
Example of
BuildReleaseArm64Truetest apk sizes difference: