Skip to content

Improve "first run" build & run time inside VS #8662

Closed
Closed
Improve "first run" build & run time inside VS#8662
Assignees
jonathanpeppers
Labels
Area: App+Library BuildIssues when building Library projects or Application projects.enhancementProposed change to current functionality.
Milestone
.NET 9

Description

@jonathanpeppers
jonathanpeppers
opened on Jan 22, 2024

Android application type

.NET Android (net7.0-android, net8.0-android, etc.)

Affected platform version

.NET 7,8,9

Description

When you build an Android project, we have logic that "finds" the property $(RuntimeIdentifier) for the attached device:

https://github.com/xamarin/monodroid/blob/867ef5e9ead84e407419e6a1f5d64a3d6583f6d5/tools/msbuild/Xamarin.Android.Common.Debugging.targets#L451-L475

If you have no device attached, it just builds all 4 $(RuntimeIdentifiers).

Problem

This can slow down the 1st time experience for MAUI on Android, as there would be no emulators running or Android devices attached. This builds 4 architectures for no reason.

Solution 1

The IDE passes $(RuntimeIdentifier) to builds. This could be problematic as right now project defaults are:

<RuntimeIdentifier></RuntimeIdentifier>
<RuntimeIdentifiers>android-arm;android-arm64;android-x86;android-x64</RuntimeIdentifiers>
<AppendRuntimeIdentifierToOutputPath>true</AppendRuntimeIdentifierToOutputPath>
<AppendRuntimeIdentifierToIntermediateOutputPath>true</AppendRuntimeIdentifierToIntermediateOutputPath>

This could have unforseen consequences, in trying to use RID for this. There are many general issues about RIDs in multi-targeted projects:

Solution 2

Invent a new property that would skip the <GetPrimaryCpu/> task and just set appropriate properties instead.

Steps to Reproduce

  1. File > New MAUI project
  2. Run in VS without an emulator running or device attached

Did you find any workaround?

No response

Relevant log output

No response

Activity

  1. jonathanpeppers
    added
    enhancementProposed change to current functionality.
    Area: App+Library BuildIssues when building Library projects or Application projects.
    on Jan 22, 2024
  2. jonathanpeppers
    added this to the .NET 9 milestone on Jan 22, 2024
  3. jonathanpeppers
    self-assigned this
    on Jan 22, 2024
  4. microsoft-github-policy-service
    added
    needs-triageIssues that need to be assigned.
    on Jan 22, 2024
  5. jonathanpeppers
    changed the title [-]Improve "first run" build & run time[/-] [+]Improve "first run" build & run time inside VS[/+] on Jan 22, 2024
  6. jonathanpeppers
    added this to .NET 9 MAUI Performance, App Size, Inner Loopon Jan 22, 2024
  7. jonathanpeppers
    moved this to Todo in .NET 9 MAUI Performance, App Size, Inner Loopon Jan 22, 2024
  8. jpobst
    removed
    needs-triageIssues that need to be assigned.
    on Jan 24, 2024
  9. jonathanpeppers
    added a commit that references this issue on Feb 12, 2024

    [Xamarin.Android.Build.Tasks] remove `$(AndroidSupportedAbis)` from `…

    afc9203
  10. dellis1972
    added a commit that references this issue on Feb 13, 2024

    [Xamarin.Android.Build.Tasks] remove `$(AndroidSupportedAbis)` from `…

    5472eec
  11. jonathanpeppers
    added a commit that references this issue on Mar 11, 2024

    [Xamarin.Android.Build.Tasks] remove `$(AndroidSupportedAbis)` from `…

    caf19b0

  12. jonathanpeppers commented on Aug 15, 2024

    @jonathanpeppers
    jonathanpeppers
    on Aug 15, 2024
    MemberAuthor

    This scenario is also improved by:

  13. jonathanpeppers commented on Aug 15, 2024

    @jonathanpeppers
    jonathanpeppers
    on Aug 15, 2024
    MemberAuthor

    The current proposal is:

    • The IDE sets a new value -p:AdbTargetArchitecture
    • At this time, the emulator is closed, adb devices doesn't report anything
    • The IDE doesn't have the value for -p:AdbTarget at this time either

    So, the build could:

    • Skip _GetPrimaryCpuAbi if $(AdbTargetArchitecture) is set
    • Set appropriate values for $(RuntimeIdentifiers), etc.

    By the time the IDE Deploys, or runs the Install target:

    • Build is complete
    • Emulator is running
    • Install will be passed -p:AdbTarget as before, and passed -p:AdbTargetArchitecture for completeness (this way _GetPrimaryCpu is skipped).

  14. jonathanpeppers commented on Aug 15, 2024

    @jonathanpeppers
    jonathanpeppers
    on Aug 15, 2024
    MemberAuthor

    /cc @dellis1972 @tondat

  15. dellis1972 commented on Aug 16, 2024

    @dellis1972
    dellis1972
    on Aug 16, 2024
    Contributor

    If the IDE knows what emulator it is going to launch before we do the build then this might work 👍

  16. jonathanpeppers
    added a commit that references this issue on Aug 20, 2024

    [tests] add test for `$(AdbTargetArchitecture)`

    83814a4
  17. jonathanpeppers
    closed this as completedon Sep 5, 2024
  18. jonathanpeppers
    closed this as completedon Sep 5, 2024
  19. github-project-automation
    moved this from Todo to Done in .NET 9 MAUI Performance, App Size, Inner Loopon Sep 5, 2024
  20. jonathanpeppers
    added 2 commits that reference this issue on Sep 5, 2024

    [tests] add test for `$(AdbTargetArchitecture)`

    0440a84

    [tests] add test for `$(AdbTargetArchitecture)` (#9227)

    d187a1d
  21. jonathanpeppers
    added 2 commits that reference this issue on Sep 23, 2024

    [tests] add test for `$(AdbTargetArchitecture)` (dotnet#9227)

    306d7cb

    [tests] add test for `$(AdbTargetArchitecture)` (#9227) (#9317)

    45bb7f3
  22. github-actions
    locked and limited conversation to collaborators on Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: App+Library BuildIssues when building Library projects or Application projects.enhancementProposed change to current functionality.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions