Repository navigation
Unify Android run targets - #12906
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical target availability and debugger setup issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Unifies Android app launching through Microsoft.Android.Run, updates debugging/profiling integration, and removes the legacy run task.
Changes:
- Adds unified run behavior with wake/no-wait semantics.
- Preserves
StartAndroidActivitycompatibility and updates debugging routes. - Updates tests, resources, and documentation.
| File | Summary |
|---|---|
tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs |
Tests unified run behavior; alias coverage remains a nit (1 vote). |
src/Xamarin.AndroidTools/Debugging/ExecutionConfiguration.cs |
Updates debugging documentation. |
src/Xamarin.Android.Build.Tasks/Xamarin.Android.Application.targets |
Adds compatibility alias; critical legacy-project target issue remains (4 votes). |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildOrderTests.cs |
Tests run argument generation. |
src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Application.targets |
Defines Run; moderate debugger setup/cleanup issue remains (1 vote). |
src/Xamarin.Android.Build.Debugging.Tasks/Xamarin.Android.Common.Debugging.targets |
Removes legacy run path and updates native debugging. |
src/Xamarin.Android.Build.Debugging.Tasks/Tasks/RunActivity.cs |
Removes obsolete task implementation. |
src/Xamarin.Android.Build.Debugging.Tasks/Properties/Resources.resx |
Removes unused resource. |
src/Xamarin.Android.Build.Debugging.Tasks/Properties/Resources.Designer.cs |
Removes generated resource accessor. |
Documentation/docs-mobile/building-apps/build-targets.md |
Documents unified run and alias behavior. |
Files not reviewed (1)
- src/Xamarin.Android.Build.Debugging.Tasks/Properties/Resources.Designer.cs: Generated file
jonathanpeppers
force-pushed
the
jonathanpeppers-unify-android-run
branch
2 times, most recently
from
September 24, 2026 20:39
8e87cd4 to
d7fdb29
Compare
Route direct Run and StartAndroidActivity invocations through Microsoft.Android.Run, and remove the legacy RunActivity implementation. Co-authored-by: Copilot App <[email protected]>
jonathanpeppers
force-pushed
the
jonathanpeppers-unify-android-run
branch
from
September 24, 2026 20:44
d7fdb29 to
6c13be6
Compare
jonathanpeppers
added this pull request to stack #12917
September 24, 2026 21:19
jonathanpeppers
added
the
ready-to-review
Member
Author
|
/review |
Contributor
|
✅ Android PR Reviewer completed successfully!
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The target consolidation and focused run-argument coverage are useful, and all reported CI checks are green. However, replacing RunActivity with Microsoft.Android.Run preserves adb port forwarding but drops the device-side managed-debugger setup and cleanup. That breaks both debugger-attached launches and the isolation of subsequent non-debug launches; the inline comments identify the two behaviors that need to be retained.
Generated by Android PR Reviewer for #12906 · copilot · gpt56 · 130 AIC · ⌖ 11.2 AIC · ⊞ 25.9K
Comment /review to run again
simonrozsival
approved these changes
Sep 25, 2026
jonathanpeppers
added a commit
that referenced
this pull request
Sep 30, 2026
- Migrate debugging-task device selection, ABI lookup, FastDeploy and app-detection to in-tree Android SDK tooling; remove the debugging tasks' project references to `Xamarin.AndroidTools` and `Mono.AndroidTools`. - Remove `GetGdbSymbols`, `ResolveXamarinAndroidTools`, and obsolete GDB debugging targets; retain `_ResolveXamarinAndroidTools` as a compatibility target for existing MSBuild dependencies. - Leave installer-side consumers and the legacy projects unchanged. The parent PR (#12906) removes `RunActivity`. Co-authored-by: Copilot App <[email protected]>
jonathanpeppers
added a commit
that referenced
this pull request
Oct 1, 2026
## Summary - Remove the `Mono.AndroidTools` and `Xamarin.AndroidTools` projects and their compiled assemblies from the workload SDK pack. - Migrate installer SDK/JDK discovery and macOS directory-size process execution to `Xamarin.Android.Tools.AndroidSdk`, preserving first-time installation when the SDK or JDK is absent. - Remove obsolete solution, build, packaging, and localization references; add installer discovery regression coverage. **Breaking change:** Tools referencing `Mono.AndroidTools.dll` or `Xamarin.AndroidTools.dll` directly must migrate to the supported shared Android SDK tooling APIs. Generated non-English `.resx` files under `src/Xamarin.AndroidTools/Properties/` remain untouched per repository localization policy; they are not compiled or packaged. Stacked on #12916 (which follows merged #12906). Co-authored-by: Copilot App <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run,_AndroidAdbToolPath, and run-argument computation inMicrosoft.Android.Sdk.Application.targetsdotnet build -t:RunthroughMicrosoft.Android.Runwith non-waiting launch behavior while still waking the deviceRunis invoked directly, matchingdotnet run's build/deploy orderingStartAndroidActivityas a compatibility alias forRun_Runtarget andRunActivitytask implementationValidation
Xamarin.Android.Build.Debugging.TaskssuccessfullyXamarin.Android.Build.TaskssuccessfullyMSBuildDeviceIntegrationsuccessfullyBuildOrderTests.ComputeRunArgumentsIncludesDebuggerPortForwardingsuccessfullyRunemits--no-waitwithout--no-wake-deviceWaitForExit=falseretains both--no-waitand--no-wake-deviceRunTargetRespectsAndroidDeviceUserIdCI binlog: the failure occurred beforeMicrosoft.Android.Runlaunched becauseInstallattempted assembly resolution beforeUnnamedProject.dllexisted; addingBuildbeforeInstallfixes that target ordering