Repository navigation
[build] Remove binary runtime config parser - #12911
Merged
simonrozsival merged 2 commits intoSep 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Removes obsolete binary runtime-config generation and related native/test metadata while preserving timing ID 9 as reserved.
Changes:
- Removes the runtime-config parser target and binary output path.
- Removes obsolete native blob constants and MonoVM test-field parsing.
- Retires the timing event description while documenting ID 9 as reserved.
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/EnvironmentHelper.cs | Updated as part of this pull request. |
| src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.RuntimeConfig.targets | Updated as part of this pull request. |
| src/native/common/include/runtime-base/timing-internal.hh | Updated as part of this pull request. |
| src/native/clr/include/constants.hh | Updated as part of this pull request. |
| Documentation/workflow/SystemProperties.md | Updated as part of this pull request. |
simonrozsival
approved these changes
Sep 24, 2026
jonathanpeppers
force-pushed
the
jonathanpeppers-remove-runtime-config-parser
branch
from
September 24, 2026 18:44
3bd8f55 to
179d02c
Compare
jonathanpeppers
force-pushed
the
jonathanpeppers-remove-runtime-config-parser
branch
from
September 24, 2026 20:47
9e9a739 to
26b467f
Compare
jonathanpeppers
force-pushed
the
jonathanpeppers-remove-runtime-config-parser
branch
from
September 25, 2026 13:20
26b467f to
ad3e216
Compare
Base automatically changed from
jonathanpeppers-workload-manifest-cleanup
to
main
September 25, 2026 16:58
jonathanpeppers
added a commit
that referenced
this pull request
Sep 25, 2026
## Summary - replace the Android workload manifest's Mono runtime and Mono AOT dependencies with the shared net10/current Mono tooling workloads still needed by `RuntimeConfigParserTask` - retain the temporary `android-deps` installer so those shared tooling packs are provisioned in local and CI SDK layouts - remove obsolete Mono/Emscripten manifest downloads and copying - retain only the CoreCLR Android runtime packs required by the native build - remove native Mono runtime paths, the empty `java-interop-mono.cc` input, and obsolete NativeAOT runtime include/link paths - remove unused current-workload version and Darc dependencies while retaining the .NET 9 Mono manifest dependency used for NuGet source discovery - temporarily skip the Release `net10.0-android36.1` CoreCLR minor-API compatibility case tracked by #12923; it should return when main moves to .NET 12 and the test advances to `net11.0-android37.1` `RuntimeConfigParserTask` and its shared tooling dependency are removed separately in the stacked follow-up #12911. Co-authored-by: Copilot App <[email protected]>
Remove the unconsumed RuntimeConfigParserTask output and the directly related native and test remnants left after MonoVM removal. Co-authored-by: Copilot App <[email protected]>
Remove unreachable MonoVM environment parsing helpers and the native constant left unused by the runtime-config cleanup. Co-authored-by: Copilot App <[email protected]>
jonathanpeppers
force-pushed
the
jonathanpeppers-remove-runtime-config-parser
branch
from
September 25, 2026 19:03
ad3e216 to
47aa4f0
Compare
simonrozsival
approved these changes
Sep 26, 2026
simonrozsival
deleted the
jonathanpeppers-remove-runtime-config-parser
branch
September 26, 2026 15:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeConfigParserTaskinvocation and binary runtime-config outputStacked on #12903.
Validation
Microsoft.Android.Sdk.RuntimeConfig.targetsas XMLXamarin.Android.Build.Tests.csprojRuntimeConfigParserTask,_BinaryRuntimeConfigPath, native runtime-config blob symbol, timing event, or test field references