Skip to content

[Xamarin.Android.Build.Tasks] ResourcePatcher for API 19+. - #2269

Merged
jonpryor merged 2 commits into
dotnet:masterfrom
dellis1972:resourcepatcher
Oct 8, 2018
Merged

[Xamarin.Android.Build.Tasks] ResourcePatcher for API 19+.#2269
jonpryor merged 2 commits into
dotnet:masterfrom
dellis1972:resourcepatcher

Conversation

@dellis1972

@dellis1972 dellis1972 commented Oct 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

The instant run fast deployment modifications are only enabled if the developer is targeting API 19 or above. So we should only include the ResourcePatcher and MonkeyPatcher files if the same conditions are met.

@dellis1972 dellis1972 added do-not-merge PR should not be merged. and removed do-not-merge PR should not be merged. labels Oct 5, 2018
@jonpryor
jonpryor merged commit 8df1f23 into dotnet:master Oct 8, 2018
grendello pushed a commit to grendello/xamarin-android that referenced this pull request Oct 8, 2018
@dellis1972 @grendello
[Xamarin.Android.Build.Tasks] ResourcePatcher for API 19+. (dotnet#…
0c0cd8d 
…2269)

The Improved Fast Deployment modifications (3f360c0) are only
enabled if the developer is targeting API-19 or above.

We should only include the `ResourcePatcher.java` and
`MonkeyPatcher.java` files if the same conditions are met.
@xamarin-release-manager xamarin-release-manager mentioned this pull request Oct 23, 2019
Closed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dellis1972 @jonpryor