Repository navigation
[Xamarin.Android.Build.Tasks] Improve the logic of GetAdditionalResourcesFromAssemblies' file validation - #292
Merged
dellis1972 merged 1 commit intoNov 14, 2016
Merged
Conversation
Validation of downloaded files in the
GetAdditionalResourcesFromAssemblies build task is currently rehashing
the same file several times during a build leading to increased build
times.
By storing the computed hash and reusing it in subsequent invocations
validation can be speed up drastically:
$ tail -n1 build_{orig,patched}.log
==> build_orig.log <==
Time Elapsed 00:07:50.9875230
==> build_patched.log <==
Time Elapsed 00:02:41.3661180
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
Hi @zappolowski, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
zappolowski
changed the title
Contributor
|
Looks good merging |
jonpryor
pushed a commit
that referenced
this pull request
Nov 18, 2016
Validation of downloaded files in the
GetAdditionalResourcesFromAssemblies build task is currently rehashing
the same file several times during a build leading to increased build
times.
By storing the computed hash and reusing it in subsequent invocations
validation can be speed up drastically:
$ tail -n1 build_{orig,patched}.log
==> build_orig.log <==
Time Elapsed 00:07:50.9875230
==> build_patched.log <==
Time Elapsed 00:02:41.3661180
radical
pushed a commit
that referenced
this pull request
May 8, 2018
This options tells the tool to generate the marshal methods only for the given type. It comes handy when woking with big assemblies like `Mono.Android.dll` and one is interested only in results for the given type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation of downloaded files in the
GetAdditionalResourcesFromAssemblies build task is currently rehashing
the same file several times during a build leading to increased build
times.
By storing the computed hash and reusing it in subsequent invocations
validation can be speed up drastically:
$ tail -n1 build_{orig,patched}.log
==> build_orig.log <==
Time Elapsed 00:07:50.9875230
==> build_patched.log <==
Time Elapsed 00:02:41.3661180