Skip to content

[Xamarin.Android.Build.Tasks] Update LintToolPath to the new location. - #582

Merged
jonpryor merged 1 commit into
dotnet:masterfrom
dellis1972:fixlint
May 11, 2017
Merged

jonpryor merged 1 commit into
dotnet:masterfrom
dellis1972:fixlint

Conversation

@dellis1972

Copy link
Copy Markdown
Contributor

Google moved the lint tool from tools to tools\bin.

@jonpryor jonpryor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably have some path probing and fallback checks so that older and newer locations are both supported.

For example, the unit tests on the PR builder are failing. :-)

Google moved the lint tool from tools to tools\bin.
@jonpryor

Copy link
Copy Markdown
Contributor

build

@jonpryor

Copy link
Copy Markdown
Contributor

On the plus side, .apk+emulator tests are now working as intended. Yay.

On the minus side, there are 18 failures in Xamarin.Android.Build.Tests.BuildTest.

@jonpryor
jonpryor merged commit 9cf367f into dotnet:master May 11, 2017
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Mar 3, 2020
Changes: dotnet/java-interop@cdf840f...b33d183

Context: dotnet/java-interop#509

  * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations  (dotnet#582)
  * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (dotnet#589)
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Mar 4, 2020
Changes: dotnet/java-interop@cdf840f...b33d183

Context: dotnet/java-interop#509

  * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations  (dotnet#582)
  * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (dotnet#589)
jonpryor added a commit that referenced this pull request Mar 4, 2020
Changes: dotnet/java-interop@cdf840f...b33d183

Context: dotnet/java-interop#509

  * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations  (#582)
  * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (#589)
jonpryor added a commit that referenced this pull request Mar 4, 2020
Changes: dotnet/java-interop@daf7fd7...3dab5a0

Context: dotnet/java-interop#509

  * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations  (#582)
  * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (#589)
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants