Repository navigation
[tests] fix 1,170 build warnings - #9137
Merged
Merged
Conversation
There are lots of warnings like:
.\dotnet-local.cmd build .\tests\Mono.Android-Tests\Runtime-Microsoft.Android.Sdk\Mono.Android.NET-Tests.csproj
...
.\tests\Mono.Android-Tests\Java.Interop\JavaConvertTest.cs(134,20):
warning CA1416: This call site is reachable on all platforms. 'Object' is only supported on: 'Android' 21.0 and later.
(https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
...
Build succeeded with 1192 warning(s) in 44.4s
Several APK test projects need to set:
<SupportedOSPlatformVersion>21</SupportedOSPlatformVersion>
In order to keep the .NET analyzer happy.
After these changes:
Build succeeded with 22 warning(s) in 38.4s
grendello
approved these changes
Jul 25, 2024
Member
Author
|
There is one MSBuild test failure we can ignore: |
grendello
added a commit
that referenced
this pull request
Jul 26, 2024
* main: [Xamarin.Android.Build.Tasks] Fix `LogCodedWarning` usage (#9148) [xaprepare] Remove Mono as required component (#9144) $(AndroidPackVersionSuffix)=rc.1; net9 is 35.0.0-rc.1 (#9143) [monodroid] treat `LocalRefsAreIndirect` as always true (#9138) [Mono.Android] fix leaking lrefs in `TypeManager` (#9136) [ci] Ignore unsigned bundletool.jar content (#9139) Localized file check-in by OneLocBuild Task (#9140) [tests] fix 1,170 build warnings (#9137) LEGO: Merge pull request 9141 Bump to xamarin/monodroid@d1d43ab161 (#9130)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are lots of warnings like:
Several APK test projects need to set:
In order to keep the .NET analyzer happy.
After these changes: