Repository navigation
Bindingsgenerator stops recognizing C# types #543
Description
I have a bindings project where we bind a Brother Printer SDK library. Starting with VS 2019 16.4.0 we get warnings about missing managed types. This is the first line of about 30:
warning BG8800: Unknown parameter type System.Collections.Generic.IList<Java.Util.Locale.LanguageRange> in method Filter in managed type Java.Util.Locale.
Compiling and linking with the app project works fine, no further warnings. I can attach the whole log if needed.
I checked the msbuild output and saw the call to the generator.exe in the Xamarin Android folder (formatted for readability):
"C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Xamarin\Android\generator.exe" ^
obj\Debug\api.xml ^
--codegen-target=XAJavaInterop1 ^
--csdir=obj\Debug\generated\src ^
--enumdir=obj\Debug\generated\enums ^
--enummetadata=obj\Debug\generated\metadata ^
--assembly=BrotherSDK.Android ^
--ref="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v1.0\mscorlib.dll" ^
--ref="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v1.0\Java.Interop.dll" ^
--ref="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v9.0\Mono.Android.dll" ^
--ref="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v1.0\System.Core.dll" ^
--ref="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v1.0\System.dll" ^
--ref="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v1.0\Facades\System.Runtime.dll" ^
--ref="C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\ReferenceAssemblies\Microsoft\Framework\MonoAndroid\v1.0\System.Xml.dll" ^
--fixup=Transforms\Metadata.xml ^
--enumfields=Transforms\EnumFields.xml ^
--enummethods=Transforms\EnumMethods.xml ^
--api-level=28 ^
--type-map-report=obj\Debug\generated\type-mapping.txt ^
--global ^
--public
When I run this command line in the project folder, I get (as expected) the same errors as in Visual Studio 2019. Now when I'm changing the path to generator.exe to use the VS 2017 generator.exe (but not changing the references to MonoAndroid assemblies), I get no warnings.
How can I fix these warnings? Or is this a regression in the generator.exe tool? Thanks!
Activity
jpobst commentedon Dec 18, 2019
I'm not aware of anything that should have changed this in 16.4. Can you provide your
api.xmlso I can try to reproduce?MFinkBK commentedon Dec 18, 2019
Here's the
api.xmlfrom theobj/Debugfolder.api.zip
jpobst commentedon Dec 18, 2019
When you say
Starting with VS 2019 16.4.0, what version were you on previously that works correctly? Are you jumping from VS2017 or were you on an earlier version of VS2019?jpobst commentedon Dec 18, 2019
I think this is caused by this change: #450.
We are attempting to resolve the type
but the key in the symbol table is
We need to either strip more arity or less.
Is this just a warning in your project? Does it actually keep any bindings from being generated?
MFinkBK commentedon Dec 19, 2019
I was upgrading from VS 2019 16.3.10. It's just warning messages, but I try to be as warnings-free as possible. At the moment I have added a Jenkins console parse rule to not mark the messages as warnings.
[generator] Fix issue where generic types couldn't be found in Symbol…
[generator] Improve generic type lookup (#552)
MFinkBK commentedon Jan 7, 2020
I see the commits in the master and the d16-5 branches. Is the fix contained in VS 2019 version 16.5.x then?
jpobst commentedon Jan 7, 2020
Yes, it will be available beginning in 16.5 Preview 2.
Bump to xamarin/Java.Interop/d16-5@c0cc7700
[JNIEnv] Add support for Kotlin's unsigned types. (#4054)
[JNIEnv] Add support for Kotlin's unsigned types. (#4054)
awattar commentedon Jan 26, 2020
What is the ETA of the 16.5 going stable?
For me this is critical as it broke my binding project due to chain of reactions that ending with whole types being removed from the generated binding.
jpobst commentedon Jan 26, 2020
I don't believe an RTM date has been announced for 16.5, however this fix is included in the 16.5 Preview 2 that came out this week. The preview installs side-by-side with your existing VS so you can use it without messing up your current VS.
https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes-preview#16.5.0-pre.2.0
awattar commentedon Jan 26, 2020
Unfortunately, I'm working on Mac and side by side preview doesn't work from some time.
[generator] Improve generic type lookup (#552)
[generator] Improve generic type lookup (dotnet#552)