IOORE importing type with name ending in a period #835

Activity

1. jpobst

   added

   bugComponent does not function as intendedComponent does not function as intended

   generatorIssues binding a Java library (generator, class-parse, etc.)Issues binding a Java library (generator, class-parse, etc.)

   on May 11, 2021
2. jpobst commented on May 11, 2021

   

   jpobst

   on May 11, 2021

   Last edited by jpobst

   ContributorAuthor

   More actions

   Notes:

   This is an issue caused by a change between firebase-firestore 22.1.1 and 22.1.2.

   Java source code: https://github.com/firebase/firebase-android-sdk/blob/master/firebase-firestore/src/main/java/com/google/firebase/firestore/model/Document.java

   Java library: https://maven.google.com/web/index.html?q=firestore#com.google.firebase:firebase-firestore:22.1.2

   Decompilation:
   

   class-parse

       <class
         abstract="false"
         deprecated="not deprecated"
         jni-extends="Ljava/lang/Object;"
         extends="java.lang.Object"
         extends-generic-aware="java.lang.Object"
         final="false"
         name="Document."
         jni-signature="Lcom/google/firebase/firestore/model/Document$;"
         source-file-name="Document.java"
         static="false"
         visibility="public" />
   

   adjusted

       <class abstract="false" deprecated="not deprecated" extends="java.lang.Object" 
   extends-generic-aware="java.lang.Object" jni-extends="Ljava/lang/Object;" final="false" 
   name="Document." static="false" visibility="public" 
   jni-signature="Lcom/google/firebase/firestore/model/Document$;"></class>
   
   
3. AmrAlSayed0 commented on May 12, 2021

   

   AmrAlSayed0

   on May 12, 2021

   More actions

   This would also help with this issue #789 (comment).
4. jonpryor commented on May 12, 2021

   

   jonpryor

   on May 12, 2021

   Contributor

   More actions

   I'm wondering about how specifically this is happening, as I cannot repro it:

   import java.util.Comparator;
   
   class Example implements Comparable<Example> {
       public int compareTo(Example a) {return 0;}
   
       static final Comparator<Example> COMPARATOR = (left, right) -> left.compareTo(right);
   
       public static Comparator<Example> keyComparator() { return COMPARATOR; }
   }

   Using both JDK 1.8 and JDK 11's javac, I do not get an Example$.class file as output. Instead, Example.COMPARATOR is implemented in terms of InvokeDynamic & a static method:

   $ javap -l -constants -c -private -s Example.class
   …
     private static int lambda$static$0(Example, Example);
       descriptor: (LExample;LExample;)I
       Code:
          0: aload_0
          1: aload_1
          2: invokevirtual dotnet/java-interop#4                  // Method compareTo:(LExample;)I
          5: ireturn
       LineNumberTable:
         line 6: 0
   
     static {};
       descriptor: ()V
       Code:
          0: invokedynamic dotnet/java-interop#5,  0              // InvokeDynamic #0:compare:()Ljava/util/Comparator;
          5: putstatic     dotnet/java-interop#2                  // Field COMPARATOR:Ljava/util/Comparator;
          8: return
       LineNumberTable:
         line 6: 0

   The lambda$static$0 method is from the lambda expression.

   (My Kotlin toolchain is screwed up, so I can't currently try to see what Kotlin would do in a similar scenario.)

   I thus don't understand where Document. is coming from. I certainly don't understand why Document. is public, of all things.
5. jonpryor commented on May 12, 2021

   

   jonpryor

   on May 12, 2021

   Contributor

   More actions

   Doubly odd is that Document.class doesn't even mention Document$.class:

   $ javap -constants -p -l -c -verbose -private -s  Document.class| grep 'Document\$'
     dotnet/java-interop#28 = Utf8               com/google/firebase/firestore/model/Document$$Lambda$1
     dotnet/java-interop#29 = Class              dotnet/java-interop#28            // com/google/firebase/firestore/model/Document$$Lambda$1
     dotnet/java-interop#33 = Methodref          dotnet/java-interop#29.#32        // com/google/firebase/firestore/model/Document$$Lambda$1.lambdaFactory$:()Ljava/util/Comparator;
            0: invokestatic  dotnet/java-interop#33                 // Method com/google/firebase/firestore/model/Document$$Lambda$1.lambdaFactory$:()Ljava/util/Comparator;
   # note: no mention of `Document$`,
   # except as part of a larger `Document$$Lambda$1`

   Document$$Lambda$1.class does mention Document$, as an invokestatic target:

     public int compare(java.lang.Object, java.lang.Object);
       descriptor: (Ljava/lang/Object;Ljava/lang/Object;)I
       flags: (0x0001) ACC_PUBLIC
       Code:
         stack=2, locals=3, args_size=3
            0: aload_1
            1: checkcast     dotnet/java-interop#14                 // class com/google/firebase/firestore/model/Document
            4: aload_2
            5: checkcast     dotnet/java-interop#14                 // class com/google/firebase/firestore/model/Document
            8: invokestatic  dotnet/java-interop#20                 // Method com/google/firebase/firestore/model/Document$.lambda$static$0:(Lcom/google/firebase/firestore/model/Document;Lcom/google/firebase/firestore/model/Document;)I
           11: ireturn
   

   I have to wonder if there's some "Java bytecode post processing" going on…
6. jonpryor commented on May 12, 2021

   

   jonpryor

   on May 12, 2021

   Contributor

   More actions

   Meanwhile, @jpobst mentioned:

   My current thought is to skip types with no effective "name" in XmlApiImporter in generator with a warning or a debug message.

   We already skip types with "obfuscated" names:

   https://github.com/xamarin/java.interop/blob/12e670a8560f69581d3a3adf0a9d91e8ce8c9afa/tools/generator/Java.Interop.Tools.Generator.Importers/XmlApiImporter.cs#L63-L72

   https://github.com/xamarin/java.interop/blob/12e670a8560f69581d3a3adf0a9d91e8ce8c9afa/tools/generator/Java.Interop.Tools.Generator.Importers/XmlApiImporter.cs#L490-L507

   so perhaps the "easy" fix is to extend IsObfuscatedName() so that Document. is treated as "obfuscated"?
7. jpobst commented on May 12, 2021

   

   jpobst

   on May 12, 2021

   ContributorAuthor

   More actions

   I have to wonder if there's some "Java bytecode post processing" going on…

   Yeah, I couldn't repro it either, and thought this might be the case.
8. jonpryor

   closed this as completedin #837on May 12, 2021
9. jonpryor

   added a commit that references this issue on May 12, 2021

   [generator] Ignore types without names (#837)

   ...

   9b89e90
10. jonpryor

    added 4 commits that reference this issue on May 20, 2021

    Bump to xamarin/Java.Interop/main@2573dc8c

    ...

    0f6a3b7

    Bump to xamarin/Java.Interop/main@2573dc8c

    ...

    2fbc2e9

    Bump to xamarin/Java.Interop/main@a5ed8919

    ...

    6124f6d

    Bump to xamarin/Java.Interop/main@a5ed8919 (#5945)

    ...

    02ab8f7
11. github-actions

    locked and limited conversation to collaborators on Apr 12, 2024
12. pull

    added a commit that references this issue on Jul 1, 2026

    [generator] Ignore types without names (#837)

    ...

    c4a99f3