Repository navigation
Annotate Microsoft.Extensions.* assemblies for nullable reference types #43605
Copy link
Copy link
Closed
Labels
User StoryA single user-facing feature. Can be grouped under an epic.A single user-facing feature. Can be grouped under an epic.area-Extensions-Primitives
Milestone
Description
In .NET 6.0, we plan to annotate Microsoft.Extensions.* assemblies built from the dotnet/runtime repo. Work involves:
- Submit individual PRs, one for each assembly. Each PR should include changes to both the src and the ref. Each PR should contain only changes related to the nullable annotations/attributes, no other changes.
- PRs can be merged once the annotations have been appropriately reviewed in PR.
In .NET 5.0, nullable references types was tracked in #2339, and remainder are being tracked in #41720 for .NET 6.0
Group 1
- Microsoft.Extensions.DependencyInjection.Abstractions
- Microsoft.Extensions.Logging.Abstractions
- Microsoft.Extensions.Primitives ([Group 1] Enable nullable annotations for
Microsoft.Extensions.Primitives#57395) - Microsoft.Extensions.FileSystemGlobbing ([Group 1] Enable nullable annotations for
Microsoft.Extensions.FileSystemGlobbing#57398) - Microsoft.Extensions.DependencyModel
Group 2
- Microsoft.Extensions.Caching.Abstractions
- Microsoft.Extensions.Configuration.Abstractions
- Microsoft.Extensions.FileProviders.Abstractions
- Microsoft.Extensions.Options
- Microsoft.Extensions.DependencyInjection
Group 3
- Microsoft.Extensions.FileProviders.Physical
- Microsoft.Extensions.FileProviders.Composite
- Microsoft.Extensions.Hosting.Abstractions
- Microsoft.Extensions.Configuration
- Microsoft.Extensions.Logging
- Microsoft.Extensions.Caching.Memory
- Microsoft.Extensions.Options.DataAnnotation
Group 4
- Microsoft.Extensions.Configuration.Binder (Check first if
System.ComponentModel.TypeConverternullable enabled) - Microsoft.Extensions.Configuration.CommandLine
- Microsoft.Extensions.Configuration.EnvironmentVariables
- Microsoft.Extensions.Configuration.FileExtensions
- Microsoft.Extensions.Http
- Microsoft.Extensions.Logging.EventLog (Check first if
System.Diagnostics.EventLognullable enabled) - Microsoft.Extensions.Logging.EventSource
- Microsoft.Extensions.Logging.TraceSource (Check first if
System.Diagnostics.TraceSourcenullable enabled) - Microsoft.Extensions.Logging.Debug
Group 5
- Microsoft.Extensions.Configuration.Ini
- Microsoft.Extensions.Configuration.Json
- Microsoft.Extensions.Configuration.Xml (Check first if
System.Security.Cryptography.Xmlnullable enabled) - Microsoft.Extensions.Options.ConfigurationExtensions
Group 6
- Microsoft.Extensions.Configuration.UserSecrets
- Microsoft.Extensions.Logging.Configuration
Group 7
- Microsoft.Extensions.Logging.Console
Group 8
- Microsoft.Extensions.Hosting
Group 9
- Microsoft.Extensions.Hosting.Systemd
- Microsoft.Extensions.Hosting.WindowsServices
Guidance here:
| # Nullability annotations |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
User StoryA single user-facing feature. Can be grouped under an epic.A single user-facing feature. Can be grouped under an epic.area-Extensions-Primitives
Type
Projects
- StatusShow more project fieldsDone
Activity
Update Microsoft.Extensions.* src csproj
krwq commentedon Jul 22, 2021
@maryamariyan I assume the remainder is not gonna happen for 6.0, correct?
25 remaining items
SteveDunn commentedon Mar 27, 2022
Thanks @maxkoshevoi - I'll just concentrate on System.Security.Cryptography.Xml. I'm down to 470 compilation errors! 😮
[Group 4] Enable nullable annotations for `Microsoft.Extensions.Loggi…
SteveDunn commentedon Mar 31, 2022
I think @maxkoshevoi has done
Microsoft.Extensions.Configuration.Xml, and I have an open PR forSystem.Security.Cryptography.Xml(#67198)SteveDunn commentedon Mar 31, 2022
I'm happy to do
Microsoft.Extensions.Httpmaxkoshevoi commentedon Mar 31, 2022
Already merged: #66891 😅
SteveDunn commentedon Mar 31, 2022
I'm too slow! :) I created a PR anyway that I don't intend to merge - I created it purely to compare with yours: SteveDunn#1
[Group 9] Enable nullable annotations for `Microsoft.Extensions.Hosti…
[Group 9] Enable nullable annotations for `Microsoft.Extensions.Hosti…