Skip to content

Annotate Microsoft.Extensions.* assemblies for nullable reference types #43605

Closed

Description

@maryamariyan

In .NET 6.0, we plan to annotate Microsoft.Extensions.* assemblies built from the dotnet/runtime repo. Work involves:

  • Submit individual PRs, one for each assembly. Each PR should include changes to both the src and the ref. Each PR should contain only changes related to the nullable annotations/attributes, no other changes.
  • PRs can be merged once the annotations have been appropriately reviewed in PR.

In .NET 5.0, nullable references types was tracked in #2339, and remainder are being tracked in #41720 for .NET 6.0

Group 1

Group 2

  • Microsoft.Extensions.Caching.Abstractions
  • Microsoft.Extensions.Configuration.Abstractions
  • Microsoft.Extensions.FileProviders.Abstractions
  • Microsoft.Extensions.Options
  • Microsoft.Extensions.DependencyInjection

Group 3

  • Microsoft.Extensions.FileProviders.Physical
  • Microsoft.Extensions.FileProviders.Composite
  • Microsoft.Extensions.Hosting.Abstractions
  • Microsoft.Extensions.Configuration
  • Microsoft.Extensions.Logging
  • Microsoft.Extensions.Caching.Memory
  • Microsoft.Extensions.Options.DataAnnotation

Group 4

  • Microsoft.Extensions.Configuration.Binder (Check first if System.ComponentModel.TypeConverter nullable enabled)
  • Microsoft.Extensions.Configuration.CommandLine
  • Microsoft.Extensions.Configuration.EnvironmentVariables
  • Microsoft.Extensions.Configuration.FileExtensions
  • Microsoft.Extensions.Http
  • Microsoft.Extensions.Logging.EventLog (Check first if System.Diagnostics.EventLog nullable enabled)
  • Microsoft.Extensions.Logging.EventSource
  • Microsoft.Extensions.Logging.TraceSource (Check first if System.Diagnostics.TraceSource nullable enabled)
  • Microsoft.Extensions.Logging.Debug

Group 5

  • Microsoft.Extensions.Configuration.Ini
  • Microsoft.Extensions.Configuration.Json
  • Microsoft.Extensions.Configuration.Xml (Check first if System.Security.Cryptography.Xml nullable enabled)
  • Microsoft.Extensions.Options.ConfigurationExtensions

Group 6

  • Microsoft.Extensions.Configuration.UserSecrets
  • Microsoft.Extensions.Logging.Configuration

Group 7

  • Microsoft.Extensions.Logging.Console

Group 8

  • Microsoft.Extensions.Hosting

Group 9

  • Microsoft.Extensions.Hosting.Systemd
  • Microsoft.Extensions.Hosting.WindowsServices

Guidance here:

Activity

  1. added and removed
    untriagedNew issue has not been triaged by the area owner
    on Nov 4, 2020
  2. added this to the 6.0.0 milestone on Nov 5, 2020
  3. added
    User StoryA single user-facing feature. Can be grouped under an epic.
    on Jan 19, 2021
  4. modified the milestones: 6.0.0, 7.0.0 on Jul 22, 2021
  5. krwq commented on Jul 22, 2021

    @krwq
    Member

    @maryamariyan I assume the remainder is not gonna happen for 6.0, correct?

  6. 25 remaining items

  7. SteveDunn commented on Mar 27, 2022

    @SteveDunn
    Contributor

    @SteveDunn regarding Microsoft.Extensions.Configuration.Xml, we decided that it's ok to annotate it without annotating System.Security.Cryptography.Xml first (#66892 (comment)), and I've already created a PR for that.

    Though PR for annotating System.Security.Cryptography.Xml would be accepted too.

    Thanks @maxkoshevoi - I'll just concentrate on System.Security.Cryptography.Xml. I'm down to 470 compilation errors! 😮

  8. SteveDunn commented on Mar 31, 2022

    @SteveDunn
    Contributor

    Microsoft.Extensions.Configuration.Xml (Check first if System.Security.Cryptography.Xml nullable enabled)

    I think @maxkoshevoi has done Microsoft.Extensions.Configuration.Xml, and I have an open PR for System.Security.Cryptography.Xml (#67198)

  9. SteveDunn commented on Mar 31, 2022

    @SteveDunn
    Contributor

    I'm happy to do Microsoft.Extensions.Http

  10. maxkoshevoi commented on Mar 31, 2022

    @maxkoshevoi
    Contributor

    I'm happy to do Microsoft.Extensions.Http

    Already merged: #66891 😅

  11. SteveDunn commented on Mar 31, 2022

    @SteveDunn
    Contributor

    I'm happy to do Microsoft.Extensions.Http

    Already merged: #66891 😅

    I'm too slow! :) I created a PR anyway that I don't intend to merge - I created it purely to compare with yours: SteveDunn#1

  12. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Apr 18, 2022
  13. Repository owner moved this from Needs Consultation to Done in Triage POD for Reflection, META, etc.on Apr 18, 2022
  14. added a commit that references this issue on Apr 18, 2022
    9849af2
  15. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Apr 18, 2022
  16. added a commit that references this issue on Apr 21, 2022
    7d8ad2f
  17. ghost locked as resolved and limited conversation to collaborators on May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions