Skip to content

[RyuJIT][arm64] Recognize madd/msub #49283

Closed
#61037
Closed
[RyuJIT][arm64] Recognize madd/msub#49283
#61037
Assignees
EgorBo
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMItenet-performancePerformance related issue
Milestone
7.0.0

Description

@EgorBo
EgorBo
opened on Mar 7, 2021

Currently for a * b + c; (integers) we emit:

  mul     w0, w0, w1
  add     w0, w0, w2

but C++ compilers emit: madd (or msub): https://godbolt.org/z/PMhq9G

Shouldn't be difficult to implement, a very simple implementation: EgorBo@8b7be3f (perhaps, it's better to introduce a new node for it since we might want to also recognize fmadd (for fp) in future in a sort of an "unsafe" math mode.

Activity

  1. EgorBo
    added
    tenet-performancePerformance related issue
    on Mar 7, 2021
  2. ghost added
    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
    on Mar 7, 2021
  3. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Mar 7, 2021
  4. EgorBo
    added this to the 6.0.0 milestone on Mar 7, 2021
  5. EgorBo
    removed
    untriagedNew issue has not been triaged by the area owner
    on Mar 7, 2021
  6. JulieLeeMSFT
    assigned
    EgorBo
    on Mar 8, 2021
  7. EgorBo
    modified the milestones: 6.0.0, Future on Mar 22, 2021
  8. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Oct 30, 2021
  9. EgorBo
    modified the milestones: Future, 7.0.0 on Oct 30, 2021
  10. EgorBo
    closed this as completedin #61037on Nov 2, 2021
  11. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Nov 2, 2021
  12. ghost locked as resolved and limited conversation to collaborators on Dec 2, 2021
  13. JulieLeeMSFT
    added this to .NET Core CodeGenon Jun 5, 2024
  14. JulieLeeMSFT
    moved this to Done in .NET Core CodeGenon Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMItenet-performancePerformance related issue

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions