Skip to content

[wasm] STJ.Serialization.Tests.JsonIgnoreAttribute_UnsupportedCollection failing on main #71981

Open
Open
[wasm] STJ.Serialization.Tests.JsonIgnoreAttribute_UnsupportedCollection failing on main#71981
Labels
arch-wasmWebAssembly architecturearea-System.Text.Jsontest-failure
Milestone
Future

Description

@radical
radical
opened on Jul 11, 2022

Build, and log:

    System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreAttribute_UnsupportedCollection [FAIL]
      System.UriFormatException : Invalid URI: The hostname could not be parsed.
      Stack Trace:
        /_/src/libraries/System.Private.Uri/src/System/UriExt.cs(42,0): at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions)
        /_/src/libraries/System.Private.Uri/src/System/Uri.cs(369,0): at System.Uri..ctor(String uriString)
        /_/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs(1193,0): at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.JsonIgnoreAttribute_UnsupportedCollection()
        --- End of stack trace from previous location ---
  Finished:    System.Text.Json.Tests

Activity

  1. ghost added
    area-System.Text.Json
    on Jul 11, 2022
  2. radical
    added
    blocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
    on Jul 11, 2022
  3. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jul 11, 2022
  5. radical
    added 2 commits that reference this issue on Jul 11, 2022

    Disable another STJ failing test - dotnet#71981

    e089914

    [wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing…

    cf83273

  6. krwq commented on Jul 12, 2022

    @krwq
    krwq
    on Jul 12, 2022
    Member

    FYI disabled tests are no longer blocking CI so removing label

  7. krwq
    removed
    blocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
    on Jul 12, 2022

  8. radical commented on Jul 12, 2022

    @radical
    radical
    on Jul 12, 2022
    MemberAuthor

    FYI disabled tests are no longer blocking CI so removing label

    Oops, sorry, missed this one!

  9. eiriktsarpalis commented on Jul 12, 2022

    @eiriktsarpalis
    eiriktsarpalis
    on Jul 12, 2022
    Member

    @radical PTAL at this comment: https://github.com/dotnet/runtime/pull/71875/files#r919266335

    Judging by the original code in this change, this appears to be a regression in System.Uri contructor validation.

  10. radical commented on Jul 12, 2022

    @radical
    radical
    on Jul 12, 2022
    MemberAuthor

    @eiriktsarpalis Do you want me to revert this, or would you want to do it as part of the fixing the validation?

  11. eiriktsarpalis commented on Jul 12, 2022

    @eiriktsarpalis
    eiriktsarpalis
    on Jul 12, 2022
    Member

    I think simply reverting the accidental change would be good for now.

  12. eiriktsarpalis
    removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 19, 2022
  13. eiriktsarpalis
    added this to the 7.0.0 milestone on Jul 19, 2022
  14. eiriktsarpalis
    added
    untriagedNew issue has not been triaged by the area owner
    on Jul 19, 2022
  15. jeffschwMSFT
    removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 20, 2022
  16. eiriktsarpalis
    added
    test-failure
    arch-wasmWebAssembly architecture
    on Aug 5, 2022
  18. radical
    modified the milestones: 7.0.0, 8.0.0 on Aug 11, 2022
  19. eiriktsarpalis
    modified the milestones: 8.0.0, Future on Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    arch-wasmWebAssembly architecturearea-System.Text.Jsontest-failure

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions