Skip to content

Remove performance runs from CI - #40540

Merged
DrewScoggins merged 1 commit into
dotnet:masterfrom
DrewScoggins:DisableNodeReuse
Aug 7, 2020
Merged

Remove performance runs from CI#40540
DrewScoggins merged 1 commit into
dotnet:masterfrom
DrewScoggins:DisableNodeReuse

Conversation

@DrewScoggins

@DrewScoggins DrewScoggins commented Aug 7, 2020

Copy link
Copy Markdown
Member

No description provided.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-Infrastructure-coreclr Only use for closed issues label Aug 7, 2020
@DrewScoggins DrewScoggins linked an issue Aug 7, 2020 that may be closed by this pull request
Performance workitems hang when trying to kill build servers at shutdown #38138
Closed
@DrewScoggins

DrewScoggins commented Aug 7, 2020

Copy link
Copy Markdown
Member Author

@danmosemsft

@DrewScoggins DrewScoggins removed a link to an issue Aug 7, 2020
Performance workitems hang when trying to kill build servers at shutdown #38138
Closed
@DrewScoggins

DrewScoggins commented Aug 7, 2020

Copy link
Copy Markdown
Member Author

To address #38138

@danmoseley

danmoseley commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Thanks. Can you help me undestand the chagne? I don't think I see any place node reuse is disabled.

BTW, I think it's still a hypothesis that disabling node reuse would help (probably a good one nevertheless). What for sure would help is a single proc build, but I'm assuming that would be unnacceptably slow.

@DrewScoggins DrewScoggins changed the title Disable node reuse for msbuild on Linux CI Remove performance runs from CI Aug 7, 2020
@DrewScoggins

DrewScoggins commented Aug 7, 2020

Copy link
Copy Markdown
Member Author

Sorry, I just changed the PR title to accurately reflect what the PR is actually doing now. Given the level of investment to be part of the CI and the value that we had received from running the perf runs as part of CI (very low in our estimation) we have just decided to disable the pr runs.

@danmoseley

danmoseley commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Sounds good, it makes sense to balance {machine scarcity, job unreliability) vs. (actual value we see it providing).

@danmoseley
danmoseley requested a review from safern August 7, 2020 19:24
@danmoseley

danmoseley commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

I can't read yaml well enough yet to review, @safern can you take a quick look?

@DrewScoggins
DrewScoggins merged commit 39b9607 into dotnet:master Aug 7, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@DrewScoggins @Jacksondr5
Remove perf CI runs (dotnet#40540)
1f9bbab
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes
@safern safern safern approved these changes
@danmoseley danmoseley Awaiting requested review from danmoseley
+1 more reviewer
@billwert billwert billwert approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-coreclr Only use for closed issues

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@DrewScoggins @danmoseley @jkoritzinsky @billwert @safern @karelz @Dotnet-GitSync-Bot