Repository navigation
docs: fix typing of message box type value - #38336
Merged
Merged
Conversation
electron-cation
Bot
added
documentation 📓
semver/patch
dsanders11
marked this pull request as ready for review
May 17, 2023 04:36
dsanders11
added
target/23-x-y
dsanders11
changed the title
codebytere
approved these changes
May 17, 2023
MarshallOfSound
approved these changes
May 17, 2023
|
No Release Notes |
Contributor
|
I was unable to backport this PR to "24-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "23-x-y" cleanly; |
trop
Bot
added
needs-manual-bp/24-x-y
needs-manual-bp/23-x-y
and removed
target/24-x-y
Contributor
|
I have automatically backported this PR to "25-x-y", please check out #38352 |
trop
Bot
added
in-flight/25-x-y
and removed
target/25-x-y
Contributor
|
@dsanders11 has manually backported this PR to "24-x-y", please check out #38375 |
dsanders11
added a commit
to dsanders11/electron
that referenced
this pull request
May 18, 2023
* docs: fix typing of dialog type value * test: add smoke tests * test: update test
Contributor
|
@dsanders11 has manually backported this PR to "23-x-y", please check out #38376 |
trop
Bot
added
in-flight/23-x-y
merged/24-x-y
codebytere
pushed a commit
that referenced
this pull request
May 22, 2023
docs: fix typing of message box type value (#38336) * docs: fix typing of dialog type value * test: add smoke tests * test: update test
trop
Bot
added
merged/23-x-y
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
These weren't being processed properly by
electron/docs-parsersince they had quotes inside of the backticks. See the Artifact Comparison check output for difference.Checklist
Release Notes
Notes: none