fix: prevent `no-unreachable-loop` crash when all loop types are ignored by Pixel998 · Pull Request #21116 · eslint/eslint

Pixel998 · 2026-07-20T10:16:10Z

Prerequisites checklist

I have read the contributing guidelines.

AI acknowledgment

I did not use AI to generate this PR.
(If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Tell us about your environment (npx eslint --env-info):

Node version: v24.16.0
npm version: v11.13.0
Local ESLint version: v10.7.0
Global ESLint version: no
Operating System: windows

What parser are you using (place an "X" next to just one item)?

[x] Default (Espree)
[ ] @typescript-eslint/parser
[ ] @babel/eslint-parser
[ ] vue-eslint-parser
[ ] @angular-eslint/template-parser
[ ] Other

Please show your full configuration:

Configuration

export default [{}];

What did you do? Please include the actual source code causing the issue.

/* eslint no-unreachable-loop: ["error", { "ignore": ["WhileStatement", "DoWhileStatement", "ForStatement", "ForInStatement", "ForOfStatement"] }] */

while (a) break;

Playground

What did you expect to happen?

The rule should ignore every loop type and produce no errors.

What actually happened? Please include the actual, raw output from ESLint.

ESLint crashed:

Error: Cannot read properties of undefined (reading 'type')

What changes did you make? (Give an overview)

Added an early return when all supported loop types are listed in ignore.

Is there anything you'd like reviewers to focus on?

netlify · 2026-07-20T10:16:15Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`b3cc3fe`
🔍 Latest deploy log	https://app.netlify.com/projects/docs-eslint/deploys/6a5df56c5eb92700086afa48

DMartens

Changes LGTM, thanks.

##### [v10.8.0](https://github.com/eslint/eslint/releases/tag/v10.8.0) #### Features - [`2fee9bb`](eslint/eslint@2fee9bb) feat: export `ConfigObject` from `eslint/config` ([#21082](eslint/eslint#21082)) (sethamus) #### Bug Fixes - [`6b8d2f7`](eslint/eslint@6b8d2f7) fix: escape reserved characters in rule id in `html` formatter ([#21129](eslint/eslint#21129)) (Francesco Trotta) - [`9091071`](eslint/eslint@9091071) fix: prevent `no-unreachable-loop` crash when all loop types are ignored ([#21116](eslint/eslint#21116)) (Pixel) - [`e23fafe`](eslint/eslint@e23fafe) fix: prefer-object-spread add semicolon when adding parenthesis ([#21081](eslint/eslint#21081)) (synthex-byte) - [`20b5ad0`](eslint/eslint@20b5ad0) fix: quadratic-time regex in `prefer-template` ([#21096](eslint/eslint#21096)) (Milos Djermanovic) - [`8b6f6c0`](eslint/eslint@8b6f6c0) fix: apply ignore configs to computed methods in class-methods-use-this ([#21094](eslint/eslint#21094)) (Pixel) - [`b2c608c`](eslint/eslint@b2c608c) fix: NewExpression with parenthesized callee in `preserve-caught-error` ([#21083](eslint/eslint#21083)) (Francesco Trotta) #### Documentation - [`6ddf858`](eslint/eslint@6ddf858) docs: fix broken Specify Parser Options anchor link ([#21106](eslint/eslint#21106)) (Minsu) - [`784dfbe`](eslint/eslint@784dfbe) docs: Clarify `no-eq-null` description ([#21120](eslint/eslint#21120)) (Park Harin) - [`7ec733a`](eslint/eslint@7ec733a) docs: Fix typos and grammar in glossary ([#21095](eslint/eslint#21095)) (Marry (Subin Yang)) - [`92bb13f`](eslint/eslint@92bb13f) docs: replace quake link ([#21108](eslint/eslint#21108)) (Jung Hyeon Jun) - [`68eb4a5`](eslint/eslint@68eb4a5) docs: fix broken Specify Globals anchor links in rule pages ([#21103](eslint/eslint#21103)) (Minsu) - [`d28f697`](eslint/eslint@d28f697) docs: replace Code Climate CLI links with Qlty CLI links ([#21099](eslint/eslint#21099)) (Jung Hyeon Jun) - [`eccc68d`](eslint/eslint@eccc68d) docs: correct --suppressions-location option description ([#21093](eslint/eslint#21093)) (Ga eun Lee) - [`c5963f7`](eslint/eslint@c5963f7) docs: Update README (GitHub Actions Bot) #### Chores - [`4fbf46d`](eslint/eslint@4fbf46d) test: pin `webpack` version to 5.108.4 ([#21137](eslint/eslint#21137)) (Francesco Trotta) - [`2d063e2`](eslint/eslint@2d063e2) chore: update HTTP URLs to HTTPS in JSDoc and comments ([#21101](eslint/eslint#21101)) (Bo Hyun Kim) - [`eccbe7b`](eslint/eslint@eccbe7b) test: add error locations to `no-class-assign` ([#21123](eslint/eslint#21123)) (devoil) - [`e7d1e43`](eslint/eslint@e7d1e43) ci: bump actions/setup-go from 6 to 7 ([#21118](eslint/eslint#21118)) (dependabot\[bot]) - [`e9d66d0`](eslint/eslint@e9d66d0) ci: bump actions/setup-node from 6 to 7 ([#21119](eslint/eslint#21119)) (dependabot\[bot]) - [`ee225b6`](eslint/eslint@ee225b6) test: Add error location details to `no-eq-null` rule ([#21117](eslint/eslint#21117)) (Park Harin) - [`044a627`](eslint/eslint@044a627) chore: update minimatch to ^10.2.5 ([#21107](eslint/eslint#21107)) (김채영) - [`fb09aa8`](eslint/eslint@fb09aa8) chore: update ecosystem plugins ([#21115](eslint/eslint#21115)) (ESLint Bot) - [`5abd878`](eslint/eslint@5abd878) test: add error locations to `no-proto` ([#21114](eslint/eslint#21114)) (Gihyeon Jeong / 정기현) - [`9715887`](eslint/eslint@9715887) test: Add error location details to `no-div-regex` ([#21110](eslint/eslint#21110)) (Park Harin) - [`a746ec6`](eslint/eslint@a746ec6) test: add error locations to `no-new-wrappers` ([#21109](eslint/eslint#21109)) (Gihyeon Jeong / 정기현) - [`8dde645`](eslint/eslint@8dde645) test: add error locations to `no-ex-assign` ([#21102](eslint/eslint#21102)) (devoil) - [`13ab0ec`](eslint/eslint@13ab0ec) test: add error locations to `no-label-var` ([#21098](eslint/eslint#21098)) (Gihyeon Jeong / 정기현) - [`a99906f`](eslint/eslint@a99906f) test: Add error location details to `no-delete-var` rule ([#21105](eslint/eslint#21105)) (Park Harin) - [`c47e8dc`](eslint/eslint@c47e8dc) chore: add missing backticks to `languages/js/index.js` ([#21104](eslint/eslint#21104)) (beeen) - [`0174428`](eslint/eslint@0174428) chore: add missing backticks to `translate-cli-options.js` ([#21097](eslint/eslint#21097)) (dongkyu lee) - [`3d36589`](eslint/eslint@3d36589) chore: add missing backticks to `serialization.js` ([#21091](eslint/eslint#21091)) (이규환) - [`dcc9312`](eslint/eslint@dcc9312) test: add error locations to `eqeqeq` ([#21090](eslint/eslint#21090)) (Ga eun Lee) - [`2710b18`](eslint/eslint@2710b18) ci: Add explicit permissions to rebuild-docs-sites workflow ([#21089](eslint/eslint#21089)) (Marry (Subin Yang)) - [`5d2f866`](eslint/eslint@5d2f866) chore: update dependency prettier to v3.9.5 ([#21086](eslint/eslint#21086)) (renovate\[bot]) - [`d584e31`](eslint/eslint@d584e31) chore: fix failing ecosystem test for `eslint-plugin-unicorn` ([#21084](eslint/eslint#21084)) (Francesco Trotta) - [`bf3eda0`](eslint/eslint@bf3eda0) chore: update ecosystem plugins ([#21079](eslint/eslint#21079)) (ESLint Bot)

##### [v10.8.0](https://github.com/eslint/eslint/releases/tag/v10.8.0) #### Features - [`2fee9bb`](eslint/eslint@2fee9bb) feat: export `ConfigObject` from `eslint/config` ([#21082](eslint/eslint#21082)) (sethamus) #### Bug Fixes - [`6b8d2f7`](eslint/eslint@6b8d2f7) fix: escape reserved characters in rule id in `html` formatter ([#21129](eslint/eslint#21129)) (Francesco Trotta) - [`9091071`](eslint/eslint@9091071) fix: prevent `no-unreachable-loop` crash when all loop types are ignored ([#21116](eslint/eslint#21116)) (Pixel) - [`e23fafe`](eslint/eslint@e23fafe) fix: prefer-object-spread add semicolon when adding parenthesis ([#21081](eslint/eslint#21081)) (synthex-byte) - [`20b5ad0`](eslint/eslint@20b5ad0) fix: quadratic-time regex in `prefer-template` ([#21096](eslint/eslint#21096)) (Milos Djermanovic) - [`8b6f6c0`](eslint/eslint@8b6f6c0) fix: apply ignore configs to computed methods in class-methods-use-this ([#21094](eslint/eslint#21094)) (Pixel) - [`b2c608c`](eslint/eslint@b2c608c) fix: NewExpression with parenthesized callee in `preserve-caught-error` ([#21083](eslint/eslint#21083)) (Francesco Trotta) #### Documentation - [`6ddf858`](eslint/eslint@6ddf858) docs: fix broken Specify Parser Options anchor link ([#21106](eslint/eslint#21106)) (Minsu) - [`784dfbe`](eslint/eslint@784dfbe) docs: Clarify `no-eq-null` description ([#21120](eslint/eslint#21120)) (Park Harin) - [`7ec733a`](eslint/eslint@7ec733a) docs: Fix typos and grammar in glossary ([#21095](eslint/eslint#21095)) (Marry (Subin Yang)) - [`92bb13f`](eslint/eslint@92bb13f) docs: replace quake link ([#21108](eslint/eslint#21108)) (Jung Hyeon Jun) - [`68eb4a5`](eslint/eslint@68eb4a5) docs: fix broken Specify Globals anchor links in rule pages ([#21103](eslint/eslint#21103)) (Minsu) - [`d28f697`](eslint/eslint@d28f697) docs: replace Code Climate CLI links with Qlty CLI links ([#21099](eslint/eslint#21099)) (Jung Hyeon Jun) - [`eccc68d`](eslint/eslint@eccc68d) docs: correct --suppressions-location option description ([#21093](eslint/eslint#21093)) (Ga eun Lee) - [`c5963f7`](eslint/eslint@c5963f7) docs: Update README (GitHub Actions Bot) #### Chores - [`4fbf46d`](eslint/eslint@4fbf46d) test: pin `webpack` version to 5.108.4 ([#21137](eslint/eslint#21137)) (Francesco Trotta) - [`2d063e2`](eslint/eslint@2d063e2) chore: update HTTP URLs to HTTPS in JSDoc and comments ([#21101](eslint/eslint#21101)) (Bo Hyun Kim) - [`eccbe7b`](eslint/eslint@eccbe7b) test: add error locations to `no-class-assign` ([#21123](eslint/eslint#21123)) (devoil) - [`e7d1e43`](eslint/eslint@e7d1e43) ci: bump actions/setup-go from 6 to 7 ([#21118](eslint/eslint#21118)) (dependabot\[bot]) - [`e9d66d0`](eslint/eslint@e9d66d0) ci: bump actions/setup-node from 6 to 7 ([#21119](eslint/eslint#21119)) (dependabot\[bot]) - [`ee225b6`](eslint/eslint@ee225b6) test: Add error location details to `no-eq-null` rule ([#21117](eslint/eslint#21117)) (Park Harin) - [`044a627`](eslint/eslint@044a627) chore: update minimatch to ^10.2.5 ([#21107](eslint/eslint#21107)) (김채영) - [`fb09aa8`](eslint/eslint@fb09aa8) chore: update ecosystem plugins ([#21115](eslint/eslint#21115)) (ESLint Bot) - [`5abd878`](eslint/eslint@5abd878) test: add error locations to `no-proto` ([#21114](eslint/eslint#21114)) (Gihyeon Jeong / 정기현) - [`9715887`](eslint/eslint@9715887) test: Add error location details to `no-div-regex` ([#21110](eslint/eslint#21110)) (Park Harin) - [`a746ec6`](eslint/eslint@a746ec6) test: add error locations to `no-new-wrappers` ([#21109](eslint/eslint#21109)) (Gihyeon Jeong / 정기현) - [`8dde645`](eslint/eslint@8dde645) test: add error locations to `no-ex-assign` ([#21102](eslint/eslint#21102)) (devoil) - [`13ab0ec`](eslint/eslint@13ab0ec) test: add error locations to `no-label-var` ([#21098](eslint/eslint#21098)) (Gihyeon Jeong / 정기현) - [`a99906f`](eslint/eslint@a99906f) test: Add error location details to `no-delete-var` rule ([#21105](eslint/eslint#21105)) (Park Harin) - [`c47e8dc`](eslint/eslint@c47e8dc) chore: add missing backticks to `languages/js/index.js` ([#21104](eslint/eslint#21104)) (beeen) - [`0174428`](eslint/eslint@0174428) chore: add missing backticks to `translate-cli-options.js` ([#21097](eslint/eslint#21097)) (dongkyu lee) - [`3d36589`](eslint/eslint@3d36589) chore: add missing backticks to `serialization.js` ([#21091](eslint/eslint#21091)) (이규환) - [`dcc9312`](eslint/eslint@dcc9312) test: add error locations to `eqeqeq` ([#21090](eslint/eslint#21090)) (Ga eun Lee) - [`2710b18`](eslint/eslint@2710b18) ci: Add explicit permissions to rebuild-docs-sites workflow ([#21089](eslint/eslint#21089)) (Marry (Subin Yang)) - [`5d2f866`](eslint/eslint@5d2f866) chore: update dependency prettier to v3.9.5 ([#21086](eslint/eslint#21086)) (renovate\[bot]) - [`d584e31`](eslint/eslint@d584e31) chore: fix failing ecosystem test for `eslint-plugin-unicorn` ([#21084](eslint/eslint#21084)) (Francesco Trotta) - [`bf3eda0`](eslint/eslint@bf3eda0) chore: update ecosystem plugins ([#21079](eslint/eslint#21079)) (ESLint Bot) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: prevent no-unreachable-loop crash when all loop types are ignored

b3cc3fe

Pixel998 requested a review from a team as a code owner July 20, 2026 10:16

eslint-github-bot Bot added the bug ESLint is working incorrectly label Jul 20, 2026

github-project-automation Bot added this to Triage Jul 20, 2026

github-project-automation Bot moved this to Needs Triage in Triage Jul 20, 2026

github-actions Bot added the rule Relates to ESLint's core rules label Jul 20, 2026

DMartens approved these changes Jul 20, 2026

View reviewed changes

DMartens merged commit 9091071 into main Jul 20, 2026
42 checks passed

DMartens deleted the fix/no-unreachable-loop-ignore-all branch July 20, 2026 21:20

github-project-automation Bot moved this from Needs Triage to Complete in Triage Jul 20, 2026

chronova-agent Bot mentioned this pull request Jul 24, 2026

chore(deps): update dependency eslint to v10.8.0 nx-solutions-ug/chronova-pi-plugin#71

Merged

1 task

github-actions Bot mentioned this pull request Jul 28, 2026

chore(deps): update dependency eslint to v10.8.0 tailor-platform/sdk#1916

Merged

1 task

mtrezza mentioned this pull request Sep 26, 2026

refactor: Bump eslint from 10.7.0 to 10.11.0 parse-community/parse-server-push-adapter#614

Merged

Navigation Menu

Uh oh!

fix: prevent `no-unreachable-loop` crash when all loop types are ignored - #21116

fix: prevent `no-unreachable-loop` crash when all loop types are ignored#21116
DMartens merged 1 commit into
mainfrom
fix/no-unreachable-loop-ignore-all

Pixel998 commented Jul 20, 2026

Uh oh!

netlify Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

DMartens left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Pixel998 commented Jul 20, 2026

Prerequisites checklist

AI acknowledgment

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

DMartens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Jul 20, 2026 •

edited

Loading