Repository navigation
Conversation
…ys so might as well get it out of the way so it doesn't get mixed in with other changes.
…format strings and fill in exception info such as the file/function/lineno in which the exception occurred. This might be useful elsewhere in Astropy but I haven't looked yet.)
|
@iguananaut - this looks fine except for one thing: changing the trig functions to Also, some of my recent changes are now conflicting with this, although I think nothing too crucial. So in the interest of moving forward, I will resolve the conflict with a manual merge. And I will also rebase your branch here to just remove the one commit that does the numpy changes. I'll be curious to see how github interprets that... Fun git times! |
… conflict resolutions and stripping numpy trig function changes
|
Interesting... so it's showing a reference, but did not close it, despite the fact that 3 of the four commits are now merged in. I'm going to go ahead and close this, since its (mostly) merged, but @iguananaut - if you disagree with my actions re: |
|
Fine by me--I'm surprised the |
|
Hmm, I'm now seeing more like 20x, as well, so I'm not sure why the 2000x was happening earlier. But 20x is still enough that it makes sense for now. But yeah, it's weird how much slower they are. We'll have to consider how we want to work around this later (when we put in arrays), I suppose. |
Don't do two copies of data on inplace operations unless it is non-contiguous and we really need to.
A few tweaks to the coordinates branch, including some PEP8 cleanup (we're nearing the end, right? It's just in this one file) and the new versions of
hours_to_string()anddegrees_to_string()I promised. Plus took care of a couple other todo items. Test seems to pass except for the two that are xfail.