Repository navigation
fix(sitemap): don't drop lastmod for an epoch (0) timestamp - #12212
Merged
Merged
Conversation
getRouteLastUpdatedAt/getRouteLastmod used truthiness checks on the
numeric lastUpdatedAt, so a legitimate timestamp of 0 (1970-01-01, e.g.
from front matter last_update: {date: 1970-01-01}) was treated as 'no
value' and the <lastmod> entry was silently omitted. The adjacent
=== null guard already shows the intent to distinguish absent from
present. Use != null so 0 is preserved.
Adds a regression test (fails before / passes after).
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Hmmm, ok to merge this but really wonder what the use case for having a lastmod with epoch 0 ? Is this only theoretical and for correctness, or do you plan to use this in practice? |
slorber
added
the
to backport
yamz8
pushed a commit
to forgente/docs
that referenced
this pull request
Jul 27, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@docusaurus/core](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fcore/3.10.1/3.10.2) |  |  | | [@docusaurus/faster](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-faster)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2ffaster/3.10.1/3.10.2) |  |  | | [@docusaurus/module-type-aliases](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-module-type-aliases)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fmodule-type-aliases/3.10.1/3.10.2) |  |  | | [@docusaurus/plugin-content-docs](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-plugin-content-docs)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fplugin-content-docs/3.10.1/3.10.2) |  |  | | [@docusaurus/preset-classic](https://github.com/facebook/docusaurus) ([source](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-preset-classic)) | [`3.10.1` → `3.10.2`](https://renovatebot.com/diffs/npm/@docusaurus%2fpreset-classic/3.10.1/3.10.2) |  |  | --- ### Release Notes <details> <summary>facebook/docusaurus (@​docusaurus/core)</summary> ### [`v3.10.2`](https://github.com/facebook/docusaurus/blob/HEAD/CHANGELOG.md#3102-2026-07-10) [Compare Source](facebook/docusaurus@v3.10.1...v3.10.2) Backport and cherry-pick commits from main for v3.10.2 patch release: - [fix(bundler): do not import `@swc/html`, fix StackBlitz playground #​12055](facebook/docusaurus#12055) - [fix(core): use locale url in site config #​12054](facebook/docusaurus#12054) - [fix(theme-classic): remove redundant sidebar label titles #​11966](facebook/docusaurus#11966) - [fix(mdx-loader): avoid transforming dotted directory links into asset… #​11944](facebook/docusaurus#11944) - [fix(dev-server): for HTTPS, support non-RSA TLS certs #​12065](facebook/docusaurus#12065) - [fix(utils): fix `extractLeadingEmoji()` edge cases #​12100](facebook/docusaurus#12100) - [fix(gtag.js, faster): Fix StackBlitz, vendor `@types/gtag.js`, upgrade `@swc/html` #​12080](facebook/docusaurus#12080) - [fix(create-docusaurus): init template README should use npm commands by default #​12138](facebook/docusaurus#12138) - [fix(cli): `docusaurus serve` should pass `--host` to `server.listen()` #​12127](facebook/docusaurus#12127) - [fix(core): bump detect-port to v2.1, fix pnpm `trustPolicy` downgrade issue #​12012](facebook/docusaurus#12012) - [fix(i18n): complete Spanish translations for theme-common and theme-l… #​12180](facebook/docusaurus#12180) - [chore(deps): migrate to `@11ty/gray-matter` #​12181](facebook/docusaurus#12181) - [fix(core): fix BaseUrlIssueBanner little security issue #​12260](facebook/docusaurus#12260) - [fix(core): accept boolean attributes in headTags config validation #​12238](facebook/docusaurus#12238) - [fix(sitemap): don't drop lastmod for an epoch (0) timestamp #​12212](facebook/docusaurus#12212) - [fix(utils): preserve author names containing commas in git log parsing #​12069](facebook/docusaurus#12069) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOTEuMiIsInVwZGF0ZWRJblZlciI6IjQzLjE5MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: Lunny Xiao <[email protected]> Reviewed-on: https://gitea.com/gitea/docs/pulls/466 Reviewed-by: Lunny Xiao <[email protected]> Co-authored-by: Renovate Bot <[email protected]>
slorber
added
backported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
createSitemapItemdecides a route's<lastmod>fromroute.metadata.lastUpdatedAt(a numeric timestamp, e.g. derived from front matterlast_update: {date: ...}). Two checks use truthiness on that number:So a legitimate timestamp of
0(1970-01-01T00:00:00Z) is treated as "no value" and the<lastmod>is silently omitted. The adjacent=== nullearly-return already shows the intent to distinguish absent from present — the truthiness checks defeat that for0.Fix
Use
!= nullin both places so0is preserved (while still treatingnull/undefinedas absent).Test plan
Added a regression test (
lastUpdatedAt: 0→lastmod: '1970-01-01') that fails before this change and passes after. Full sitemap package: 53 tests pass.