Repository navigation
fix: callNotFound should run not-found preHandler regardless of registration order - #6965
Merged
climba03003 merged 2 commits intoAug 23, 2026
Conversation
…tration order setContext() in four-oh-four.js took a detached shallow snapshot of the selected not-found context. When a route that calls reply.callNotFound() is registered before setNotFoundHandler(), the snapshot is taken before the not-found handler's preReady callback populates its lifecycle hooks, so the copied context retains preHandler: null. reply.callNotFound() then dispatches the not-found handler directly, skipping the preHandler that setNotFoundHandler() declares. Use the selected context as the prototype instead, keeping the route's own onSend value, so the route-specific 404 context stays linked to the live one and later hook population is visible. Adds a regression test covering the route-first declaration order.
Object.create already handles a null context; the ?? null fallback only covered an unreachable undefined path and dropped four-oh-four.js branch coverage below the enforced threshold.
metcoder95
approved these changes
Aug 20, 2026
climba03003
added
the
backport 5.x
climba03003
pushed a commit
that referenced
this pull request
Aug 23, 2026
…rdless of registration order (#6973) Backport 4176096 from #6965. Co-authored-by: Matteo Collina <[email protected]> Co-authored-by: mcollina <[email protected]>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setContext() in four-oh-four.js takes a detached shallow snapshot of the
selected not-found context. When a route that calls reply.callNotFound()
is registered before setNotFoundHandler(), the snapshot is taken before
the not-found handler's preReady callback populates its lifecycle hooks,
so the copied context retains preHandler: null. reply.callNotFound() then
dispatches the not-found handler directly, skipping the preHandler that
setNotFoundHandler() declares.
This change uses the selected context as the prototype of the route-specific
404 context instead of copying it, keeping the route's own onSend value, so
the route-specific context stays linked to the live one and later hook
population is visible.
Adds a regression test covering the route-first declaration order.