Use lazy encoding in utf-8 encoded string comparison - #6706
Merged
Merged
Conversation
Contributor
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 25.1.3 {: #firestore_v25-1-3}
* {{fixed}} Use lazy encoding in UTF-8 encoded byte comparison for strings to solve performance issues. GitHub [#6706](//github.com/firebase/firebase-android-sdk/issues/6706){: .external}
* {{changed}} Updated `protolite-well-known-types` dependency to `18.0.1`. GitHub [#6716](//github.com/firebase/firebase-android-sdk/issues/6716){: .external}
#### {{firestore}} Kotlin extensions version 25.1.3 {: #firestore-ktx_v25-1-3}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.
|
Collaborator
Coverage Report 1Affected Products
Test Logs |
Contributor
Test Results 186 files - 848 186 suites - 848 4m 42s ⏱️ - 29m 31s Results for commit 629b394. ± Comparison against base commit ad7618b. This pull request removes 4657 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Collaborator
Size Report 1Affected Products
Test Logs |
ehsannas
reviewed
Feb 19, 2025
ehsannas
approved these changes
Feb 26, 2025
tejasd
pushed a commit
that referenced
this pull request
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix created a performance issue due to expensive UTF-8 encoding. Update
compareUtf8Stringsto use lazy encoding instead.