Skip to content

Change shebang for run_sdk_container - #3814

Merged
chewi merged 1 commit into
flatcar:mainfrom
robinschneider:mac-dev
Mar 10, 2026
Merged

chewi merged 1 commit into
flatcar:mainfrom
robinschneider:mac-dev

Conversation

@robinschneider

Copy link
Copy Markdown
Member

Change shebang for run_sdk_container

Updated shebang for the run_sdk_container.
Before this change, it was not possible to run the dev container on macOS.
macOS 26.3 still uses bash 3.2, which is insufficient here.

❯ ./run_sdk_container -t

###### Writing versionfile 'sdk_container/.repo/manifests/version.txt' to SDK '4634.0.0+nightly-20260309-2100', OS '4634.0.0+nightly-20260309-2100-1-gb13ae6c070'. ######

###### Creating a new container 'flatcar-sdk-all-4634.0.0-nightly-20260309-2100_os-main-4634.0.0-nightly-20260309-2100-1-gb13ae6c070' ######
sdk_lib/sdk_container_common.sh: line 279: local: -n: invalid option
local: usage: local name[=value] ...

With this change, you can use gnu bash on macOS and run the dev container without any further changes.
https://formulae.brew.sh/formula/bash

According to StackOverflow, this is also superior over #!/bin/bash and recommended in general.
https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash

How to use

You can test, if the container does still run with ./run_sdk_container -t

Testing done

I have tested this on macOS as well as Ubuntu.

@robinschneider
robinschneider requested a review from a team as a code owner March 10, 2026 13:23

@chewi chewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For distributions, I would say that /bin/bash is almost always the right choice, but in this particular case, which is not running in a Flatcar environment, I agree that this change makes sense.

@chewi
chewi merged commit 9e810cd into flatcar:main Mar 10, 2026
4 checks passed
@tormath1

Copy link
Copy Markdown
Contributor

@chewi any chance to backport this to maintenance channel? I think this would be beneficial for folks using "old" SDK (e.g for stable development)

@chewi

chewi commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Backported to 4628, 4593, 4459, 4081.

John15321 added a commit to flatcar/Flatcar that referenced this pull request Apr 29, 2026
This PR adds Robin Schneider (@robinschneider) as a Flatcar maintainer.
Adding Robin was proposed on the Maintainers private email list, the
vote was successful (simple majority, no dissentient vote).

The CNCF registries will be updated shortly. 

---

Proposal for reference:

Hello team,

I would like to propose including Robin Schneider[1] as a Flatcar
maintainer. Robin has been a very active participant in the Flatcar
community, regularly helping users, sharing practical feedback, and
contributing to discussions across several areas of the project. He has
also contributed to Flatcar infrastructure and provider enablement work,
and has expressed interest in supporting the infrastructure side of the
project wherever possible. Having him within the maintainer team will
greatly help the project.

Some of Robin's work includes:
- Adding STACKIT as a supported cloud provider for Flatcar by providing
the OEM image integration[2]
- Adding STACKIT provider testing support and CI automation for vendor
testing[3]
- Documenting Flatcar usage on STACKIT for users and operators[4]
- Improving the development workflow by fixing the SDK container startup
on macOS[5]
- Updating the NVIDIA GPU usage documentation, including installation,
container verification, and Kubernetes usage[6]
- Investigating and driving work around getting the NVIDIA GPU Operator
working on Flatcar[7]
- Actively participating in the Flatcar community, helping users, and
bringing practical production-user feedback to the project

Please submit your vote via this email.

[1] https://github.com/robinschneider
[2] flatcar/scripts#3018
[3] flatcar/scripts#3287
[4] flatcar/flatcar-website#456
[5] flatcar/scripts#3814
[6] flatcar/flatcar-website#515
[7] #1962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants