Repository navigation
run: Ignore system bus failures in parental controls check - #5609
Merged
Merged
Conversation
dbnicholson
added a commit
to endlessm/flatpak
that referenced
this pull request
Nov 29, 2023
Currently if the parental controls check can't connect to the system bus, apps are not allowed to run. However, apps are also allowed to run if the malcontent (or accounts-service) D-Bus services aren't available. Since it's trivial to meet that requirement by starting a temporary dbus-daemon and setting `DBUS_SYSTEM_BUS_ADDRESS` to use it, not being able to access the system bus at all is no less secure. This primarily affects flatpak running in a container where D-Bus is generally not available. Fixes: #5076 (cherry picked from commit 3f0a4c717db53e198838b9e1e8895dda0b073f5d) Upstream: flatpak/flatpak#5609 https://phabricator.endlessm.com/T35067
dbnicholson
added a commit
to endlessm/flatpak
that referenced
this pull request
Nov 30, 2023
Currently if the parental controls check can't connect to the system bus, apps are not allowed to run. However, apps are also allowed to run if the malcontent (or accounts-service) D-Bus services aren't available. Since it's trivial to meet that requirement by starting a temporary dbus-daemon and setting `DBUS_SYSTEM_BUS_ADDRESS` to use it, not being able to access the system bus at all is no less secure. This primarily affects flatpak running in a container where D-Bus is generally not available. Fixes: #5076 (cherry picked from commit 3f0a4c717db53e198838b9e1e8895dda0b073f5d) Upstream: flatpak/flatpak#5609 https://phabricator.endlessm.com/T35067
Collaborator
|
Looks reasonable to me, but I'd like an ack from @pwithnall as the author of this feature. |
This was referenced Nov 30, 2023
Collaborator
|
I’m happy if you’re happy. Too much human time and effort has been wasted (across so many projects) on the fact that containers, for some reason, don’t have D-Bus 😞 |
smcv
approved these changes
Dec 5, 2023
Currently if the parental controls check can't connect to the system bus, apps are not allowed to run. However, apps are also allowed to run if the malcontent (or accounts-service) D-Bus services aren't available. Since it's trivial to meet that requirement by starting a temporary dbus-daemon and setting `DBUS_SYSTEM_BUS_ADDRESS` to use it, not being able to access the system bus at all is no less secure. This primarily affects flatpak running in a container where D-Bus is generally not available. Fixes: flatpak#5076
smcv
force-pushed
the
malcontent-system-bus
branch
from
December 5, 2023 13:55
3f0a4c7 to
c1c4e1c
Compare
bbhtt
pushed a commit
to flathub-infra/flatpak
that referenced
this pull request
May 27, 2026
Being unable to access the system-bus is nto a security boundry since, in that case it's trivial to start your own session and set DBUS_SYSTEM_BUS_ADDRESS. This is the same fix as 3afdfd2 but for handling installation instead. See said commit for more details. Adapted from flatpak#5609 Fixes flatpak#5076 Co-authored-by: Dan Nicholson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the parental controls check can't connect to the system bus, apps are not allowed to run. However, apps are also allowed to run if the malcontent (or accounts-service) D-Bus services aren't available. Since it's trivial to meet that requirement by starting a temporary dbus-daemon and setting
DBUS_SYSTEM_BUS_ADDRESSto use it, not being able to access the system bus at all is no less secure.This primarily affects flatpak running in a container where D-Bus is generally not available.
Fixes: #5076