Repository navigation
tests: Check that flatpak-run fd-arguments do not leak to the command - #6594
Merged
Merged
Conversation
flatpak-run takes a number of arguments which are file descriptor numbers. Those file descriptors are supposed to set something up in the way the instance gets spawned, but should never make it to the wrapper command.
Collaborator
|
I've been trying to do a version of this that asserts that the fds that are open are exactly those that we expect. I'll push that when I get it working and we can compare notes. |
smcv
approved these changes
Apr 10, 2026
smcv
left a comment
smcv
left a comment
Collaborator
There was a problem hiding this comment.
Yeah, let's have this, and we can back it out if it proves to be unreliable, or have my more systematic version as well (or instead) if we like that better.
Collaborator
This is #6599. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flatpak-run takes a number of arguments which are file descriptor numbers. Those file descriptors are supposed to set something up in the way the instance gets spawned, but should never make it to the wrapper command.
I thought this was unreliable, but I tested this in a loop for an hour and it never succeeded when it should not.