Repository navigation
Conversation
These fds are stdin, stdout and stderr respectively, and are expected to remain open at all times (if they are not needed then they can point to /dev/null, but they should always be open). If the user gives us `--env-fd=2` or similar, we don't want to close fd 2 before exiting unsuccessfully: that would give us nowhere to display the error message. Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
We don't know what fds our tests are going to inherit from the user or the test framework, but we can use this wrapper to enforce that none of them are passed to Flatpak, allowing us to make assertions about what fds remain open. Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
Signed-off-by: Simon McVittie <[email protected]>
smcv
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #6598 to avoid conflicts.
utils: Add flatpak_unset_cloexec()
tests: Add a helper to close all inherited fds, with exceptions
We don't know what fds our tests are going to inherit from the user or
the test framework, but we can use this wrapper to enforce that none
of them are passed to Flatpak, allowing us to make assertions about
what fds remain open.
tests: Add a helper to assert that a specified set of fds are open
tests: Assert that extraneous fds aren't inherited into the sandbox