Repository navigation
document-export: Parse the AddNamed reply for --noexist - #6847
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Looks fine, but would be nice to fix the shell check issues |
9ddb76e to
be1d715
Compare
|
@swick should be fixed, sorry, forgot about these, cause of another branch also throwing shell check :) |
|
Let's get #6848 merged first so you can rebase on top of that for the test setup. |
With --noexist, the opened file descriptor refers to the parent directory. The request correctly uses AddNamed, but is_directory makes the reply parser expect AddFull's array reply instead of AddNamed's single string. This produces a GVariant type mismatch and crashes the command. Only select the AddFull reply parser for directory exports without --noexist, matching the method used for the request.
Exercise existing files, directories and nonexistent files against a real document portal on the private test bus. Verify that --noexist returns a usable export after the origin is created and preserves its read grant. The regression fails on the AddNamed reply type mismatch without the fix. All four checks pass with it.
be1d715 to
e17ac7d
Compare
This doesn't really make it obvious what user-facing bug you were fixing with this change, and I had to reverse-engineer it while updating the release notes. In future it would be helpful for MRs that fix a bug to contain a solution-neutral problem statement for what bug is being fixed, or a link to an issue report with a solution-neutral problem statement. |
4 participants
With --noexist, the opened file descriptor refers to the parent directory.
The request correctly uses AddNamed, but is_directory makes the reply
parser expect AddFull's array reply instead of AddNamed's single string.
This produces a GVariant type mismatch and crashes the command.
Only select the AddFull reply parser for directory exports without
--noexist, matching the method used for the request.