Repository navigation
Removing Gold checks on non-master branches - #800
Merged
Merged
Conversation
christopherfujino
approved these changes
Jun 5, 2020
christopherfujino
left a comment
christopherfujino
left a comment
Contributor
There was a problem hiding this comment.
LGTM! thanks @Piinks
keyonghan
approved these changes
Jun 5, 2020
| if ((lastUpdate.status == GithubGoldStatusUpdate.statusCompleted && | ||
| lastUpdate.head == pr.head.sha) || | ||
| (pr.base.ref != 'master')) { | ||
| log.debug('Completed status already reported for this commit.'); |
Contributor
There was a problem hiding this comment.
Nit: you want to update your below doc here too?
Contributor
Author
There was a problem hiding this comment.
Whoops! Looks like I just missed this.
I'll send a quick nit follow up. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: flutter/flutter#58627 flutter/flutter#58814
This removes the gold check from branches that are not staged to land on master (i.e. release branches) We've been hitting Github API rate limits, so this should help cut back on those requests.