Repository navigation
Release branches should skip skia_gold tests, others only meant to pass on master #58814
Description
Activity
Related #53371
This should be pretty easy. We added some branching support for gold specifically in flutter/cocoon#727. It'll be easy to tell from the base ref of the pr if gold should bother with it.
Reacted by Christopher Fujinoflutter/cocoon#800 should trim things down a bit. :)
Reacted by Christopher FujinoTriage: what's remaining?
Goldens are skipped on release branches, @christopherfujino what else should be skipped?
Reacted by Christopher FujinoGoldens are skipped on release branches, @christopherfujino what else should be skipped?
Cool, I didn't realize we were skipping goldens on release branches, awesome. I'll close this now.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Aug 18, 2021
Certain CI tests, (e.g. skia_gold goldens tests) are currently set up with the assumption that they will be run pre/post submit against master. This means that they are almost certain to fail on release branches, where the code is between weeks and months old. It is important that CI for release branches are kept as green as possible, so that legitimate regressions are immediately identified.
Where possible, tests should be modified to accurately test older release code (e.g. #57062). This issue is specifically tracking skipping tests that would be either impossible or extremely difficult to support multiple release branches.