Skip to content

Validation on the input before connect request is triggered... #1612

Description

@jwren

On the launch page (devtools_app/lib/src/flutter/connect_screen.dart), there should be some validation on the input URL, if I for instance enter random text inserted into connect box in the Connect box where a URL goes, an attempt is made and I see the popup:

Unable to connect to 'random text insterted into connect box'

Activity

  1. kenzieschmoll commented on Feb 7, 2020

    @kenzieschmoll
    Member

    We have this feature in the flutter version of Devtools already:
    Screen Shot 2020-02-07 at 1 04 29 PM

  2. kenzieschmoll commented on Feb 7, 2020

    @kenzieschmoll
    Member

    Talked to Jaime offline - we show a different message if the connection is unavailable "Unable to connect...", so we have the logic to distinguish between a failed connection and an invalid link.

    Instead of allowing the connect button to be clicked anyway when the link is not valid, we should disable the connect button and make the outline of the text field red.

  3. added this to the On Deck milestone on Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions