You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Validation on the input before connect request is triggered... #1612
On the launch page (devtools_app/lib/src/flutter/connect_screen.dart), there should be some validation on the input URL, if I for instance enter random text inserted into connect box in the Connect box where a URL goes, an attempt is made and I see the popup:
Unable to connect to 'random text insterted into connect box'
Talked to Jaime offline - we show a different message if the connection is unavailable "Unable to connect...", so we have the logic to distinguish between a failed connection and an invalid link.
Instead of allowing the connect button to be clicked anyway when the link is not valid, we should disable the connect button and make the outline of the text field red.
Activity
kenzieschmoll commentedon Feb 7, 2020
We have this feature in the flutter version of Devtools already:

kenzieschmoll commentedon Feb 7, 2020
Talked to Jaime offline - we show a different message if the connection is unavailable "Unable to connect...", so we have the logic to distinguish between a failed connection and an invalid link.
Instead of allowing the connect button to be clicked anyway when the link is not valid, we should disable the connect button and make the outline of the text field red.