Skip to content

Migrate from flutter/material.dart to material_ui/material_ui.dart - #10016

Merged
johnpryan merged 19 commits into
flutter:masterfrom
johnpryan:material_migrate
Sep 24, 2026
Merged

johnpryan merged 19 commits into
flutter:masterfrom
johnpryan:material_migrate

Conversation

@johnpryan

Copy link
Copy Markdown
Contributor

This applies the migration using dart fix:

dart fix --apply --code=migrate_design_widgets

This is the first step towards resolving #10015.

This applies the migration using dart fix:

```
dart fix --apply --code=migrate_design_widgets
```

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces imports of the official Flutter SDK libraries ('package:flutter/material.dart' and 'package:flutter/cupertino.dart') with untrusted external packages ('package:material_ui/material_ui.dart' and 'package:cupertino_ui/cupertino_ui.dart') across numerous files, and adds these external packages as dependencies in 'pubspec.yaml'. The reviewer correctly flagged these changes as critical security risks (potential supply chain attacks) and import violations, instructing to revert the dependency additions and restore the official Flutter SDK imports.

Comment thread packages/devtools_app/pubspec.yaml Outdated
Comment thread packages/devtools_app/test/screens/debugger/syntax_highlighter_test.dart Outdated

@srawlins srawlins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@johnpryan johnpryan self-assigned this Sep 23, 2026
Explicitly apply theme text styles to MarkdownStyleSheet in SidePanel
to fix dark theme contrast after migrating to package:material_ui.
Also update the memory diff goldens to match the rendered upload icon.
@johnpryan
johnpryan merged commit 405689b into flutter:master Sep 24, 2026
51 checks passed
auto-submit Bot pushed a commit to flutter/tests that referenced this pull request Sep 29, 2026
Updates DevTools commit hash to [405689bc49f9c7ae0d7ca77b3d9b0f698745989b](flutter/devtools@405689b).

This incorporates flutter/devtools#10016 which migrates DevTools from `flutter/material.dart` to `material_ui/material_ui.dart` for flutter/flutter#192957.
pull Bot pushed a commit to dhc-tech/flutter that referenced this pull request Sep 29, 2026
…3511)

Bumps the customer testing pinned commit from `9853d38` to
[`51bbf1a`](flutter/tests@51bbf1a)
to pick up:
- flutter/tests#496 (updates DevTools to
flutter/devtools#10016)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants