Repository navigation
Fix blurriness on focused line in code view - #5732
Conversation
| @@ -1207,7 +1207,7 @@ class _LineItemState extends State<LineItem> | |||
| // to allow us to render this as a proper overlay as similar | |||
| // functionality exists to render the selection handles properly. | |||
| Opacity( | |||
There was a problem hiding this comment.
what is the point of using a completely transparent opacity widget now?
There was a problem hiding this comment.
is the comment above this widget still relevant?
|
If everything is WAI with the Opacity widget removed, then maybe that is stale code that we don't need? |
|
Oh wait a minute, with opacity 0 the text doesn't show up at all. I was getting this backwards for some reason thinking that we were laying a transparent widget on top of the text instead of hiding the text itself. The comment makes sense now. LGTM, then. Whether we can remove the workaround in the comment or not, doing so may be out of scope. |
|
unless you've already applied a fix and verified things are WAI with your last commit :) |
Just removed it by using our |
| // 'Icons.label_important' icon. | ||
| const colIconSize = 13.0; | ||
| const colLeftOffset = -3.0; | ||
| final colLeftOffset = -3.0 + widthToCurrentColumn; |
There was a problem hiding this comment.
nit: change to widthToCurrentColumn - 3.0 (if the 3 is still needed here? a comment could help)
2 participants
Fixes #5708
Work towards #5703
Before:
After: