Skip to content

Rename devtools_app_shared's Split to SplitPane - #7328

Merged
guidezpl merged 7 commits into
masterfrom
rename-split
Mar 8, 2024
Merged

guidezpl merged 7 commits into
masterfrom
rename-split

Conversation

@guidezpl

@guidezpl guidezpl commented Mar 6, 2024 •

Copy link
Copy Markdown
Member

This renaming will allow flutter/flutter#143130 to land. devtools_app_shared is bumped to 0.1.0.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

Comment thread packages/devtools_app_shared/lib/src/ui/split_pane.dart
Comment thread packages/devtools_app/pubspec.yaml Outdated

@kenzieschmoll kenzieschmoll left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one pubspec change

@guidezpl
guidezpl marked this pull request as ready for review March 7, 2024 22:41
@guidezpl
guidezpl requested review from a team, CoderDake, bkonyi, elliette and polina-c as code owners March 7, 2024 22:41
@kenzieschmoll

Copy link
Copy Markdown
Member

If you run devtools_tool fix-goldens --run-id=8195797648 you can download the new golden images to your local branch. If the golden updates look good, feel free to commit them to this PR. Since we run off of bleeding edge flutter, we deal with some golden churn at times.

@guidezpl
guidezpl merged commit aeb3d7b into master Mar 8, 2024
@guidezpl
guidezpl deleted the rename-split branch March 8, 2024 07:20
guidezpl added a commit to flutter/tests that referenced this pull request Mar 11, 2024
Update the hash to the commit for
flutter/devtools#7328

Part of flutter/flutter#51627

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants