Repository navigation
Update inspector integration tests to handle Flutter breaking change - #9226
Merged
Merged
Conversation
bkonyi
approved these changes
May 30, 2025
This was referenced May 30, 2025
hrajwade96
pushed a commit
to hrajwade96/devtools
that referenced
this pull request
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9206
flutter/flutter#169229 changes the number of widgets in the inspector tree, affecting our inspector integration tests.
This PR updates how we find a row in the tree. We now look for the row below "MaterialApp" instead of the row matching "71 more widgets..." (since this text has now changed to "72 more widgets...").
The changes in flutter/flutter#169229 will also affect a few of the goldens we are comparing against, so I've skipped them for now.
After flutter/flutter#169229 lands and DevTools' Flutter version includes flutter/flutter#169229, they will need to be un-skipped and the goldens can be updated.