Repository navigation
Commit 88ef361
Add progress indicator to artifact downloads (#181808)
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This is a first step towards resolving
#14268. This change adds a
simple progress indicator telling the user how many artifact (sets) need
downloading. The output also makes the structure of artifact sets
clearer by indenting the artifacts inside a set.
Here is the output of downloading all artifacts:
<details><summary>Details</summary>
<p>
```
❯ flutter precache -f -a
Building flutter tool...
Resolving dependencies...
Downloading packages...
Got dependencies.
Downloading Flutter dependencies...
[1/18] Material Fonts 278ms
[2/18] Gradle Wrapper 28ms
[3/18] Android SDK
├─ [1/21] android-arm-profile/darwin-x64 303ms
├─ [2/21] android-arm-release/darwin-x64 243ms
├─ [3/21] android-arm64-profile/darwin-x64 787ms
├─ [4/21] android-arm64-release/darwin-x64 235ms
├─ [5/21] android-x64-profile/darwin-x64 365ms
├─ [6/21] android-x64-release/darwin-x64 249ms
├─ [7/21] android-arm-profile/linux-x64 189ms
├─ [8/21] android-arm-release/linux-x64 181ms
├─ [9/21] android-arm64-profile/linux-x64 184ms
├─ [10/21] android-arm64-release/linux-x64 1,009ms
├─ [11/21] android-x64-profile/linux-x64 275ms
├─ [12/21] android-x64-release/linux-x64 179ms
├─ [13/21] android-arm-profile/windows-x64 164ms
├─ [14/21] android-arm-release/windows-x64 178ms
├─ [15/21] android-arm64-profile/windows-x64 187ms
├─ [16/21] android-arm64-release/windows-x64 183ms
├─ [17/21] android-x64-profile/windows-x64 996ms
├─ [18/21] android-x64-release/windows-x64 193ms
├─ [19/21] dart-sdk-darwin-x64 6.6s
├─ [20/21] dart-sdk-linux-x64 5.5s
└─ [21/21] dart-sdk-windows-x64 5.3s
[4/18] Android Internal Build Artifacts
├─ [1/10] android-x86 4.8s
├─ [2/10] android-x64 4.8s
├─ [3/10] android-arm 4.9s
├─ [4/10] android-arm-profile 2,507ms
├─ [5/10] android-arm-release 1,626ms
├─ [6/10] android-arm64 5.0s
├─ [7/10] android-arm64-profile 2,204ms
├─ [8/10] android-arm64-release 2,161ms
├─ [9/10] android-x64-profile 2,374ms
└─ [10/10] android-x64-release 2,179ms
[5/18] iOS SDK
├─ [1/3] ios 3.1s
├─ [2/3] ios-profile 2,606ms
└─ [3/3] ios-release 4.0s
[6/18] Web SDK 2,075ms
[7/18] Engine Information 161ms
[8/18] Flutter SDK
├─ [1/7] sky_engine 144ms
├─ [2/7] flutter_gpu 358ms
├─ [3/7] flutter_patched_sdk 202ms
├─ [4/7] flutter_patched_sdk_product 179ms
├─ [5/7] windows-x64 2,010ms
├─ [6/7] linux-x64 1,652ms
└─ [7/7] darwin-x64 1,856ms
[9/18] Windows SDK
├─ [1/4] windows-x64-debug/windows-x64-flutter 3.1s
├─ [2/4] windows-x64/flutter-cpp-client-wrapper 147ms
├─ [3/4] windows-x64-profile/windows-x64-flutter 3.6s
└─ [4/4] windows-x64-release/windows-x64-flutter 3.6s
[10/18] MacOS SDK
├─ [1/8] darwin-x64/framework 2,017ms
├─ [2/8] darwin-x64/gen_snapshot 1,204ms
├─ [3/8] darwin-x64-profile/framework 1,329ms
├─ [4/8] darwin-x64-profile 978ms
├─ [5/8] darwin-x64-profile/gen_snapshot 680ms
├─ [6/8] darwin-x64-release/framework 3.9s
├─ [7/8] darwin-x64-release 1,006ms
└─ [8/8] darwin-x64-release/gen_snapshot 1,271ms
[11/18] Linux SDK
├─ [1/3] linux-x64-debug/linux-x64-flutter-gtk 2,293ms
├─ [2/3] linux-x64-profile/linux-x64-flutter-gtk 1,485ms
└─ [3/3] linux-x64-release/linux-x64-flutter-gtk 1,462ms
[12/18] iOS USB Artifact: libimobiledevice 43ms
[13/18] iOS USB Artifact: libusbmuxd 34ms
[14/18] iOS USB Artifact: libplist 25ms
[15/18] iOS USB Artifact: openssl 55ms
[16/18] iOS USB Artifact: libimobiledeviceglue 26ms
[17/18] iOS USB Artifact: ios-deploy 26ms
[18/18] Font Subsets
├─ [1/3] darwin-x64/font-subset 956ms
├─ [2/3] linux-x64/font-subset 172ms
└─ [3/3] windows-x64/font-subset 168ms
```
</p>
</details>
Each artifact set now has a pretty display name.
It would look nicer if the iOS USB artifacts were bundled in one
artifact set but maybe there is a reason why they are separate?
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Ben Konyi <[email protected]>1 parent 4f5478c commit 88ef361
3 files changed
Lines changed: 301 additions & 56 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
744 | 744 | | |
745 | 745 | | |
746 | 746 | | |
747 | | - | |
748 | | - | |
749 | | - | |
750 | | - | |
751 | | - | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
752 | 753 | | |
753 | 754 | | |
754 | 755 | | |
| |||
757 | 758 | | |
758 | 759 | | |
759 | 760 | | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
760 | 796 | | |
761 | 797 | | |
762 | 798 | | |
| |||
771 | 807 | | |
772 | 808 | | |
773 | 809 | | |
| 810 | + | |
774 | 811 | | |
775 | 812 | | |
776 | 813 | | |
| |||
828 | 865 | | |
829 | 866 | | |
830 | 867 | | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
831 | 873 | | |
832 | 874 | | |
833 | 875 | | |
834 | 876 | | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
835 | 882 | | |
836 | 883 | | |
837 | 884 | | |
| |||
930 | 977 | | |
931 | 978 | | |
932 | 979 | | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
933 | 983 | | |
934 | 984 | | |
935 | 985 | | |
| |||
975 | 1025 | | |
976 | 1026 | | |
977 | 1027 | | |
978 | | - | |
979 | | - | |
980 | | - | |
981 | | - | |
982 | | - | |
| 1028 | + | |
983 | 1029 | | |
984 | 1030 | | |
985 | 1031 | | |
986 | 1032 | | |
987 | 1033 | | |
988 | 1034 | | |
989 | 1035 | | |
990 | | - | |
991 | 1036 | | |
992 | | - | |
993 | | - | |
994 | | - | |
995 | | - | |
996 | | - | |
| 1037 | + | |
997 | 1038 | | |
998 | 1039 | | |
999 | 1040 | | |
| |||
1094 | 1135 | | |
1095 | 1136 | | |
1096 | 1137 | | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
1097 | 1168 | | |
1098 | 1169 | | |
1099 | 1170 | | |
| |||
1112 | 1183 | | |
1113 | 1184 | | |
1114 | 1185 | | |
1115 | | - | |
1116 | | - | |
| 1186 | + | |
| 1187 | + | |
1117 | 1188 | | |
1118 | 1189 | | |
1119 | 1190 | | |
1120 | | - | |
1121 | | - | |
| 1191 | + | |
| 1192 | + | |
1122 | 1193 | | |
1123 | 1194 | | |
1124 | 1195 | | |
1125 | | - | |
1126 | | - | |
| 1196 | + | |
| 1197 | + | |
1127 | 1198 | | |
1128 | 1199 | | |
1129 | 1200 | | |
1130 | 1201 | | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
1131 | 1214 | | |
1132 | 1215 | | |
1133 | | - | |
| 1216 | + | |
1134 | 1217 | | |
1135 | 1218 | | |
1136 | 1219 | | |
| |||
1139 | 1222 | | |
1140 | 1223 | | |
1141 | 1224 | | |
| 1225 | + | |
| 1226 | + | |
1142 | 1227 | | |
1143 | 1228 | | |
1144 | | - | |
| 1229 | + | |
1145 | 1230 | | |
1146 | 1231 | | |
1147 | 1232 | | |
| |||
0 commit comments