Repository navigation
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 42132e879b42
head repository: flutter/flutter
compare: fe71cadf1959
- 12 commits
- 22 files changed
- 9 contributors
Commits on Oct 29, 2024
-
Fix and remove a few
no-shuffletags influtter_tools. (#157656)Two of the tests, `test_test` and `break_on_framework_exceptions`, no longer appear to leak (without changes). Perhaps underlying infrastructure has changed, or some other bug in the tool itself was fixed in meantime. `packages_test` required resetting `Cache.flutterRoot`. Work towards #85160.
Configuration menu - View commit details
-
Copy full SHA for 1068d31 - Browse repository at this point
Copy the full SHA 1068d31View commit details -
Roll Flutter Engine from 725c8e4 to 795b549 (5 revisions) (#157820)
flutter-team-archive/engine@725c8e4...795b549 2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] disable AHBs on devices that were upgraded to 29. (#56202)" (flutter-team-archive/engine#56212) 2024-10-29 [email protected] Remove --time run of gen_snapshot. (flutter-team-archive/engine#56204) 2024-10-29 [email protected] [Impeller] Clip the DrawImageRect source rect to the bounds of the image (flutter-team-archive/engine#56183) 2024-10-29 [email protected] [Impeller] disable Maleoon GPU from using Vulkan. (flutter-team-archive/engine#56203) 2024-10-29 [email protected] [Impeller] disable AHBs on devices that were upgraded to 29. (flutter-team-archive/engine#56202) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 3ed40f0 - Browse repository at this point
Copy the full SHA 3ed40f0View commit details -
Roll Packages from e0c4f55 to 028027e (8 revisions) (#157813)
flutter/packages@e0c4f55...028027e 2024-10-29 [email protected] [various] Remove multiDexEnabled (flutter/packages#7956) 2024-10-28 [email protected] Roll Flutter from 5a11904 to 3fb95c7 (16 revisions) (flutter/packages#7948) 2024-10-28 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMACompanionAdSlot` and `IMACompanionDelegate` (flutter/packages#7889) 2024-10-27 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/packages#7919) 2024-10-26 [email protected] Roll Flutter from 4faa4a4 to 5a11904 (67 revisions) (flutter/packages#7937) 2024-10-25 [email protected] Drop deprecated web library (flutter/packages#7926) 2024-10-25 [email protected] [video_player_web] Don't modify volume when muting video (flutter/packages#7845) 2024-10-25 [email protected] Roll Flutter (stable) from 2663184 to 6031040 (3 revisions) (flutter/packages#7930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 8b7d0c3 - Browse repository at this point
Copy the full SHA 8b7d0c3View commit details -
Avoid labeling all PRs as 'text-input' (#157805)
After #157650 all PRs are being labeled as text-input by the PR labeler. I think the config is missing an `all` based on the [negation example](https://github.com/actions/labeler/blob/main/README.md#basic-examples)
Configuration menu - View commit details
-
Copy full SHA for 7c27a05 - Browse repository at this point
Copy the full SHA 7c27a05View commit details -
Roll Flutter Engine from 795b549 to 999797a (1 revision) (#157825)
flutter-team-archive/engine@795b549...999797a 2024-10-29 [email protected] [Impeller] disable Adreno 506. (flutter-team-archive/engine#56210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 4731859 - Browse repository at this point
Copy the full SHA 4731859View commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ee7fff - Browse repository at this point
Copy the full SHA 7ee7fffView commit details -
Add boundary feature to the drag gesture. (#147521)
Inspired by the review on #146182. This PR adds boundary feature to the drag gestures, including `MultiDragGestureRecognizer` and `DragGestureRecognizer`. The `GestureDetector` widget will also benefit from this.
Configuration menu - View commit details
-
Copy full SHA for c051b69 - Browse repository at this point
Copy the full SHA c051b69View commit details -
Add test for
scroll_metrics_notification.0.dart(#157768)Contributes to #130459 It adds a test for - `examples/api/lib/widgets/scroll_position/scroll_metrics_notification.0.dart`
Configuration menu - View commit details
-
Copy full SHA for 1ec1c59 - Browse repository at this point
Copy the full SHA 1ec1c59View commit details -
Add test for
interactive_viewer.0.dart(#157773)Contributes to #130459 It adds a test for - `examples/api/lib/widgets/interactive_viewer/interactive_viewer.0.dart`
Configuration menu - View commit details
-
Copy full SHA for f9c130a - Browse repository at this point
Copy the full SHA f9c130aView commit details -
Fix menu anchor state handling (#157612)
This commit refactors the `_MenuAnchorState` class in `menu_anchor.dart` to include a check for the mounted state and the scheduler phase before calling `setState()`. This ensures that UI updates are only performed when the widget is still mounted and not during the persistent callbacks phase. Additionally, a new test case is added in `menu_anchor_test.dart` to verify that the `isOpen` state of the `MenuAnchor` widget is updated correctly when the button is pressed. Fix: #157606 *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Configuration menu - View commit details
-
Copy full SHA for ec50578 - Browse repository at this point
Copy the full SHA ec50578View commit details -
Add ability to customize the default
Sliderpadding (#156143)Fixes [Ability to change Sliders padding](#40098) Add ability to override default padding so the Slider can fit better in a layout. ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatefulWidget { const MyApp({super.key}); @OverRide State<MyApp> createState() => _MyAppState(); } class _MyAppState extends State<MyApp> { double _sliderValue = 0.5; @OverRide Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData( sliderTheme: const SliderThemeData( padding: EdgeInsets.symmetric(vertical: 4.0), thumbColor: Colors.red, inactiveTrackColor: Colors.amber, ), ), home: Scaffold( body: Directionality( textDirection: TextDirection.ltr, child: Center( child: Card( shape: const RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(4.0)), ), color: Theme.of(context).colorScheme.surfaceContainerHighest, margin: const EdgeInsets.symmetric(horizontal: 16.0), child: Padding( padding: const EdgeInsets.all(16.0), child: Column( mainAxisSize: MainAxisSize.min, children: [ const Placeholder(fallbackHeight: 100.0), Slider( value: _sliderValue, onChanged: (double value) { setState(() { _sliderValue = value; }); }, ), const Placeholder(fallbackHeight: 100.0), ], ), ), ), ), ), ), ); } } ``` </details> ### Before (Cannot adjust default `Slider` padding to fill the horizontal space in a `Column` and reduce the padded height) <img width="717" alt="Screenshot 2024-10-03 at 15 45 18" src="https://github.com/user-attachments/assets/e9d9a4d1-3087-45b4-8607-b94411e2bd23"> ### After Can adjust default `Slider` padding via `SliderTheme`) <img width="717" alt="Screenshot 2024-10-03 at 15 46 25" src="https://github.com/user-attachments/assets/cd455881-6d52-46cb-8ac6-cc33f50a13ff">
Configuration menu - View commit details
-
Copy full SHA for 40c2274 - Browse repository at this point
Copy the full SHA 40c2274View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe71cad - Browse repository at this point
Copy the full SHA fe71cadView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 42132e879b42...fe71cadf1959