Skip to content

Fix and remove a few no-shuffle tags in flutter_tools. - #157656

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
matanlurey:remove-flutter-test-no-shuffle
Oct 29, 2024
Merged

auto-submit[bot] merged 3 commits into
flutter:masterfrom
matanlurey:remove-flutter-test-no-shuffle

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Two of the tests, test_test and break_on_framework_exceptions, no longer appear to leak (without changes). Perhaps underlying infrastructure has changed, or some other bug in the tool itself was fixed in meantime.

packages_test required resetting Cache.flutterRoot.

Work towards #85160.

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 26, 2024

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

void main() {
late FakeStdio mockStdio;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove whitespace...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grr

@matanlurey
matanlurey removed the request for review from andrewkolos October 29, 2024 17:52
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024
@auto-submit
auto-submit Bot merged commit 1068d31 into flutter:master Oct 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 30, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Oct 30, 2024
flutter/flutter@42132e8...fe71cad

2024-10-30 [email protected] Update CHANGELOG.md to correct ios vs macos issue (flutter/flutter#157822)
2024-10-30 [email protected] Add ability to customize the default `Slider` padding (flutter/flutter#156143)
2024-10-30 [email protected] Fix menu anchor state handling (flutter/flutter#157612)
2024-10-30 [email protected] Add test for `interactive_viewer.0.dart` (flutter/flutter#157773)
2024-10-30 [email protected] Add test for `scroll_metrics_notification.0.dart` (flutter/flutter#157768)
2024-10-30 [email protected] Add boundary feature to the drag gesture. (flutter/flutter#147521)
2024-10-30 [email protected] Fix `ResizeImage` documentation (flutter/flutter#157619)
2024-10-29 [email protected] Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) (flutter/flutter#157825)
2024-10-29 [email protected] Avoid labeling all PRs as 'text-input' (flutter/flutter#157805)
2024-10-29 [email protected] Roll Packages from e0c4f55 to 028027e (8 revisions) (flutter/flutter#157813)
2024-10-29 [email protected] Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) (flutter/flutter#157820)
2024-10-29 [email protected] Fix and remove a few `no-shuffle` tags in `flutter_tools`. (flutter/flutter#157656)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@42132e8...fe71cad

2024-10-30 [email protected] Update CHANGELOG.md to correct ios vs macos issue (flutter/flutter#157822)
2024-10-30 [email protected] Add ability to customize the default `Slider` padding (flutter/flutter#156143)
2024-10-30 [email protected] Fix menu anchor state handling (flutter/flutter#157612)
2024-10-30 [email protected] Add test for `interactive_viewer.0.dart` (flutter/flutter#157773)
2024-10-30 [email protected] Add test for `scroll_metrics_notification.0.dart` (flutter/flutter#157768)
2024-10-30 [email protected] Add boundary feature to the drag gesture. (flutter/flutter#147521)
2024-10-30 [email protected] Fix `ResizeImage` documentation (flutter/flutter#157619)
2024-10-29 [email protected] Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) (flutter/flutter#157825)
2024-10-29 [email protected] Avoid labeling all PRs as 'text-input' (flutter/flutter#157805)
2024-10-29 [email protected] Roll Packages from e0c4f55 to 028027e (8 revisions) (flutter/flutter#157813)
2024-10-29 [email protected] Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) (flutter/flutter#157820)
2024-10-29 [email protected] Fix and remove a few `no-shuffle` tags in `flutter_tools`. (flutter/flutter#157656)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@42132e8...fe71cad

2024-10-30 [email protected] Update CHANGELOG.md to correct ios vs macos issue (flutter/flutter#157822)
2024-10-30 [email protected] Add ability to customize the default `Slider` padding (flutter/flutter#156143)
2024-10-30 [email protected] Fix menu anchor state handling (flutter/flutter#157612)
2024-10-30 [email protected] Add test for `interactive_viewer.0.dart` (flutter/flutter#157773)
2024-10-30 [email protected] Add test for `scroll_metrics_notification.0.dart` (flutter/flutter#157768)
2024-10-30 [email protected] Add boundary feature to the drag gesture. (flutter/flutter#147521)
2024-10-30 [email protected] Fix `ResizeImage` documentation (flutter/flutter#157619)
2024-10-29 [email protected] Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) (flutter/flutter#157825)
2024-10-29 [email protected] Avoid labeling all PRs as 'text-input' (flutter/flutter#157805)
2024-10-29 [email protected] Roll Packages from 8447f5d to dda8fe3 (8 revisions) (flutter/flutter#157813)
2024-10-29 [email protected] Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) (flutter/flutter#157820)
2024-10-29 [email protected] Fix and remove a few `no-shuffle` tags in `flutter_tools`. (flutter/flutter#157656)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants