Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5a556f8ecde6
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6f227c078430
Choose a head ref
  • 11 commits
  • 29 files changed
  • 8 contributors

Commits on Aug 18, 2023

  1. fixes l10n for CupertinoDatePicker in monthYear mode (#130934)

    This PR fixes l10n issue when months names are being used in incorrect form in CupertinoDatePicker in CupertinoDatePickerMode.yearMonth (#130930).
    
    The idea of this proposal is to add an optional parameter `standalone` for `CupertinoLocalizations.datePickerMonth` to be able to choose when to use months names in base form (intl DateSymbols.STANDALONEMONTHS) and when in day-dependent form (intl DateSymbols.MONTHS)
    
    <details>
    <summary>Before</summary>
    
    <img width="366" alt="image" src="https://github.com/flutter/flutter/assets/32621121/1dd54fa7-6dd9-4053-889b-57134c145432">
    
    <img width="387" alt="image" src="https://github.com/flutter/flutter/assets/32621121/c176070e-73e4-49d3-883b-ba31eca6d1d7">
    
    </details>
    
    <details>
    <summary>After</summary>
    
    <img width="369" alt="image" src="https://github.com/flutter/flutter/assets/32621121/255594f1-219d-4bd4-9b75-1012912f8ab0">
    
    <img width="378" alt="image" src="https://github.com/flutter/flutter/assets/32621121/16bbb41f-3f62-4446-bf41-e27140b649a9">
    
    </details>
    AndreySuworow authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    1cfba26 View commit details
    Browse the repository at this point in the history
  2. Add a new MatrixTransition and refactor ScaleTransition and RotationT… (

    #131084)
    
    �ransition to derive from it.
    
    The MatrixTransition class uses a callback to handle any value => Matrix animation.
    
    The alignment and filterQuality logic that was in ScaleTransition and RotationTransition is now factored in MatrixTransition.
    
    The ScaleTransition.scale and RotationTransition.turns getters had to be kept because they're still referenced in https://github.com/flutter/packages/tree/main/packages/animations, and https://github.com/flutter/packages/flutter/test/. I plan to remove the references there, once this PR is generally available, and then remove the getters here.
    
    A RotationTransition test was updated to use matrixMoreOrLessEquals because using Matrix4.rotationZ doesn't have the special cases Transform.Rotation had, and zeroes in matrix weren't exactly zeroes.
    
    fixes #130946
    gmilou authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    58019b3 View commit details
    Browse the repository at this point in the history
  3. doc: add flag params (#132485)

    *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    0o001 authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6875827 View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 58f7d8e to 83fdada (7 revisions) (#132857)

    flutter-team-archive/engine@58f7d8e...83fdada
    
    2023-08-18 [email protected] Update Impeller
    benchmarks.md with a Pixel 7 link (flutter-team-archive/engine#44834)
    2023-08-18 [email protected] Roll Fuchsia Linux SDK from
    7xOzci7fempFgHNk9... to pSqQ556xmZp7S4np5... (flutter-team-archive/engine#44846)
    2023-08-18 [email protected] Roll Dart SDK from
    121fcbd8124c to 8109103e041b (1 revision) (flutter-team-archive/engine#44844)
    2023-08-18 [email protected] [Impeller] add trace events for
    VkRenderPass and VkFrameBuffer creation. (flutter-team-archive/engine#44837)
    2023-08-18 [email protected] Roll Fuchsia Mac SDK from
    Tnp43n_nAR2N0l_gY... to onEHyyETXAMieDyfP... (flutter-team-archive/engine#44845)
    2023-08-18 [email protected] Roll Skia from 1e62a2d4c429 to
    c9294edc03b9 (2 revisions) (flutter-team-archive/engine#44843)
    2023-08-18 [email protected] [Android] Expose channel buffer resize
    and overflow calls (flutter-team-archive/engine#44434)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from 7xOzci7fempF to pSqQ556xmZp7
      fuchsia/sdk/core/mac-amd64 from Tnp43n_nAR2N to onEHyyETXAMi
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6cefc2e View commit details
    Browse the repository at this point in the history
  5. Updates app link gradle tasks and remove vm services (#131805)

    1. Remove vm service registration
    2. combine print<variant>ApplicationId and print<variant>AppLinkDomain into one task dump<variant>AppLinkSettings, which dump all the data in a json file
    
    The deeplink validation tool will be a static app in devtool instead of regular app. A Static app doesn't require a running app; therefore, we can't call these API through vmservices. I decided to convert these API into flutter analyzer command, which will be done in a separate PR #131009.
    
    The reason these print tasks are converted into file dumps is to reduce the amount of data encoding and decoding. Instead of passing data through stdout, the devtool can read the files generated by gradle tasks instead.
    chunhtai authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    61242fa View commit details
    Browse the repository at this point in the history
  6. Roll Flutter Engine from 83fdada to 72c4e61 (2 revisions) (#132861)

    flutter-team-archive/engine@83fdada...72c4e61
    
    2023-08-18 [email protected] Roll Skia from 31baf15e8f2c to e3adabdd0511 (2 revisions) (flutter-team-archive/engine#44851)
    2023-08-18 [email protected] Roll Skia from c9294edc03b9 to 31baf15e8f2c (10 revisions) (flutter-team-archive/engine#44850)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    58171f0 View commit details
    Browse the repository at this point in the history
  7. Roll Flutter Engine from 72c4e61 to 654d3a2 (3 revisions) (#132868)

    flutter-team-archive/engine@72c4e61...654d3a2
    
    2023-08-18 [email protected] Roll Skia from edf0c0ecc7b1 to cf37d99d844d (1 revision) (flutter-team-archive/engine#44857)
    2023-08-18 [email protected] Roll Skia from e3adabdd0511 to edf0c0ecc7b1 (3 revisions) (flutter-team-archive/engine#44854)
    2023-08-18 [email protected] Flush pending graphics commands when the unref queue is drained on the IO thread (flutter-team-archive/engine#44831)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    1bdef6f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d5a162b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2ecb886 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Roll Flutter Engine from 654d3a2 to f4bffdc (5 revisions) (#132876)

    flutter-team-archive/engine@654d3a2...f4bffdc
    
    2023-08-18 [email protected] Allow optional codepoints to be expressed to the font subset generator. (flutter-team-archive/engine#44864)
    2023-08-18 [email protected] Roll Skia from 2ddec49abd5c to e9cf3f1740eb (3 revisions) (flutter-team-archive/engine#44862)
    2023-08-18 [email protected] Roll Skia from 2dd1ed0baa7d to 2ddec49abd5c (2 revisions) (flutter-team-archive/engine#44860)
    2023-08-18 [email protected] Roll Skia from cf37d99d844d to 2dd1ed0baa7d (1 revision) (flutter-team-archive/engine#44859)
    2023-08-18 [email protected] Roll Dart SDK from 8109103e041b to a4908f67b63e (2 revisions) (flutter-team-archive/engine#44858)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Aug 19, 2023
    Configuration menu
    Copy the full SHA
    6d75704 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f227c0 View commit details
    Browse the repository at this point in the history
Loading