Repository navigation
Boiletplate Android Manifest misses required attributes #1006
Description
After trying to publish a Flutter-created app to Google Play, it noticed me that some required pieces were missing from the AndroidManifest.xml file.
- the
android:versionCodeandandroid:versionNameattributes in<manifest> android:iconin<application>, although this attribute requires the presence of an actual icon drawable
Activity
devoncarew commentedon Dec 21, 2015
@stevenroose, the code to generate the manifest file lives here: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/init.dart#L226 if you want to try your hand at a PR. I'm less familiar with those constants and what they should default to.
stevenroose commentedon Dec 21, 2015
I'm pretty new to Android dev too, but I'll see. Thing is that for me to
fix the icon part, I need to actually upload an icon or else the app cant
run. Should I create a dummy Flutter logo-based icon?
On Mon, Dec 21, 2015 at 8:12 PM, Devon Carew [email protected]
wrote:
devoncarew commentedon Dec 21, 2015
I think we should have an icon in there, if that's what's needed to to publish the sample. You could probably either just add a comment to the manifest file, or add an icon to the generated app, based off the flutter logo.
eseidelGoogle commentedon Dec 21, 2015
I'm also not 100% sure if the
flutter apkcommand signs with the correct key, which you definitely want to do before publishing. On my system it uses the chromium dev keys, presumably on a non-dev system it would have prompted for personal android signing keys? I suspect that @jason-simmons thought of this when he wroteflutter apk, i just haven't tested proper signing personally.It looks like
flutter apkis hardcoded to teh chromium signing key:https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/commands/apk.dart#L146
You don't want to publish with that key. :( We will need to fix the command.
abarth commentedon Dec 21, 2015
I believe it always uses the Chromium dev key. Would you be willing to file a bug about improving the command?
sethladd commentedon Dec 21, 2015
Should we open a new issue?
eseidelGoogle commentedon Dec 21, 2015
Filed #1010
eseidelGoogle commentedon Dec 21, 2015
To answer the earlier question, @stevenroose, we should include a default icon. I recommend using the simple flutter one from material_gallery (and then we should give material_gallery a nicer one):
https://github.com/flutter/flutter/tree/master/examples/material_gallery/apk
eseidelGoogle commentedon Jan 26, 2016
We probably need this for the Hackathon. The initial
flutter initflow needs to produce a working (and ideally store-compatible) app.stevenroose commentedon Jan 26, 2016
What hackathon when?? :)
1 remaining item
stevenroose commentedon Jan 26, 2016
Bummer. Well, I'm curious. Flutter could indeed benefit from a huge
documentation improvement. However boring to provide, it's inevitable for
adoption.
On Tue, Jan 26, 2016 at 2:37 AM, Eric Seidel [email protected]
wrote:
eseidelGoogle commentedon Jan 26, 2016
Please feel encouraged to file bugs against our documentation shortcomings. @qchong recently joined our project and is working explicitly on making sure we have a coherent technical writeups of flutter and how to use it. Other members of the team have slowly been adding more dartdocs to the code, which are generated by our builders and appear at https://docs.flutter.io immediately after they are landed in the repository.
Make flutter create generate a manifest that is similar to SkyShell.a…
Add versionCode and versionName to default Android manifest
Bump android_alarm_manager version to 0.2.3 (flutter#1006)
github-actions commentedon Sep 6, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.